From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100349 invoked by alias); 6 Sep 2017 15:26:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100339 invoked by uid 89); 6 Sep 2017 15:26:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 15:26:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 521C315AD for ; Wed, 6 Sep 2017 08:26:43 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F00E03F578 for ; Wed, 6 Sep 2017 08:26:42 -0700 (PDT) To: GDB Patches From: Thomas Preudhomme Subject: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp Message-ID: <58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com> Date: Wed, 06 Sep 2017 15:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D1DE6619426DE68C8DE71D48" X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00152.txt.bz2 This is a multi-part message in MIME format. --------------D1DE6619426DE68C8DE71D48 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 595 Hi, Tests in gdb.arch/thumb2-it.exp call functions defined in assembly without type debugging information. Since 7022349d5c86bae74b49225515f42d2e221bd368 this triggers an error which leads to many tests to FAIL. This patch cast the call to indicate the return type of the functions when calling them. ChangeLog entry is as follows: *** gdb/testsuite/ChangeLog *** 2017-09-06 Thomas Preud'homme * gdb.arch/thumb2-it.exp: Cast call to assembly defined function. All tests in that exp file PASS after that change. Is this ok for master? Best regards, Thomas --------------D1DE6619426DE68C8DE71D48 Content-Type: text/x-patch; name="fix_thumb2-it_exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_thumb2-it_exp.patch" Content-length: 795 diff --git a/gdb/testsuite/gdb.arch/thumb2-it.exp b/gdb/testsuite/gdb.arch/thumb2-it.exp index ab0dae38e302cdfef0232780612ea9a2f36d7f54..e100d068b3a92f24fb1bd0f8ffaedcc58d7512a8 100644 --- a/gdb/testsuite/gdb.arch/thumb2-it.exp +++ b/gdb/testsuite/gdb.arch/thumb2-it.exp @@ -58,7 +58,7 @@ proc test_it_block { func } { return } - gdb_test "call ${func}()" "Breakpoint.*@ Setup.*" "$func, call" + gdb_test "call (int) ${func}()" "Breakpoint.*@ Setup.*" "$func, call" set expected 0 set reached 0 @@ -155,7 +155,7 @@ for { set i 1 } { $i <= 8 } { incr i } { } gdb_breakpoint "*it_breakpoints" -gdb_test "call it_breakpoints()" "Breakpoint.*" +gdb_test "call (int) it_breakpoints()" "Breakpoint.*" for { set i 1 } { $i <= 7 } { incr i } { test_it_break ${i} } --------------D1DE6619426DE68C8DE71D48--