[PATCH] Add a missing munmap_list move constructor

[Saagar Jha <saagar@saagarjha.com>]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

Clang warns if the default implementation of a function is requested but it is implicitly deleted. This was happening to compile_module because it didn’t have a move constructor for its munmap_list member, so I went ahead and added one since it already had a move assignment operator defined for it and this seemed like an oversight.


[-- Attachment #2: Add-a-missing-munmap_list-move-constructor.patch --]
[-- Type: application/octet-stream, Size: 1486 bytes --]

From 3ed7e54dfc5b3ab0a6033a239f8d6a457cb91f92 Mon Sep 17 00:00:00 2001
From: Saagar Jha <saagar@saagarjha.com>
Date: Wed, 23 Sep 2020 22:16:17 -0700
Subject: [PATCH] Add a missing munmap_list move constructor

compile_module attempts to request a move constructor, but because
munmap_list doesn't have one it gets implicitly deleted. This is an
warning on clang under -Wdefaulted-function-deleted (which is enabled by
default).

gdb/ChangeLog:

	* compile/compile-object-load.h: Give munmap_list a move
	constructor.
---
 gdb/ChangeLog                     | 5 +++++
 gdb/compile/compile-object-load.h | 1 +
 2 files changed, 6 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 241f3e7027..3aa3255b37 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-09-23  Saagar Jha  <saagar@saagarjha.com>
+
+	* compile/compile-object-load.h: Give munmap_list a move
+	constructor.
+
 2020-09-23  Tom Tromey  <tom@tromey.com>
 
 	PR symtab/25470:
diff --git a/gdb/compile/compile-object-load.h b/gdb/compile/compile-object-load.h
index 0254390109..166d442ad0 100644
--- a/gdb/compile/compile-object-load.h
+++ b/gdb/compile/compile-object-load.h
@@ -30,6 +30,7 @@ struct munmap_list
   DISABLE_COPY_AND_ASSIGN (munmap_list);
 
   munmap_list &operator= (munmap_list &&) = default;
+  munmap_list (munmap_list &&) = default;
 
   /* Add a region to the list.  */
   void add (CORE_ADDR addr, CORE_ADDR size);
-- 
2.28.0