Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Saagar Jha <saagar@saagarjha.com>
To: gdb-patches@sourceware.org
Cc: Saagar Jha <saagar@saagarjha.com>
Subject: [PATCH] Add a missing munmap_list move constructor
Date: Fri, 25 Sep 2020 00:05:24 -0700	[thread overview]
Message-ID: <20200925070525.47993-1-saagar@saagarjha.com> (raw)
In-Reply-To: <883A80DB-0918-4BA6-B387-A54581BFEA42@saagarjha.com>

compile_module attempts to request a move constructor, but because
munmap_list doesn't have one it gets implicitly deleted. This is an
warning on clang under -Wdefaulted-function-deleted (which is enabled by
default):

In file included from compile/compile-object-load.c:21:
compile/compile-object-load.h:56:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  compile_module (compile_module &&other) = default;
  ^
compile/compile-object-load.h:86:22: note: move constructor of 'compile_module' is implicitly deleted because field 'munmap_list' has a deleted move constructor
  struct munmap_list munmap_list;
                     ^
compile/compile-object-load.h:30:28: note: 'munmap_list' has been explicitly marked deleted here
  DISABLE_COPY_AND_ASSIGN (munmap_list);
                           ^

gdb/ChangeLog:

	* compile/compile-object-load.h: Give munmap_list a move
	constructor.
---
 gdb/ChangeLog                     | 5 +++++
 gdb/compile/compile-object-load.h | 1 +
 2 files changed, 6 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3872a8d9cb..043c6a4c72 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-09-25  Saagar Jha  <saagar@saagarjha.com>
+
+	* compile/compile-object-load.h: Give munmap_list a move
+	constructor.
+
 2020-09-24  Tom Tromey  <tromey@adacore.com>
 
 	PR tui/26638:
diff --git a/gdb/compile/compile-object-load.h b/gdb/compile/compile-object-load.h
index 0254390109..166d442ad0 100644
--- a/gdb/compile/compile-object-load.h
+++ b/gdb/compile/compile-object-load.h
@@ -30,6 +30,7 @@ struct munmap_list
   DISABLE_COPY_AND_ASSIGN (munmap_list);
 
   munmap_list &operator= (munmap_list &&) = default;
+  munmap_list (munmap_list &&) = default;
 
   /* Add a region to the list.  */
   void add (CORE_ADDR addr, CORE_ADDR size);
-- 
2.28.0


  reply	other threads:[~2020-09-25  7:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24  5:22 Saagar Jha
2020-09-24 15:27 ` Simon Marchi
2020-09-25  6:59   ` Saagar Jha
2020-09-25  7:05     ` Saagar Jha [this message]
2020-09-25  7:05       ` Saagar Jha
2020-09-25 14:58       ` Simon Marchi
2020-09-26  0:25         ` Saagar Jha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925070525.47993-1-saagar@saagarjha.com \
    --to=saagar@saagarjha.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox