From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tgYPKO2WbV/pFQAAWB0awg (envelope-from ) for ; Fri, 25 Sep 2020 03:06:21 -0400 Received: by simark.ca (Postfix, from userid 112) id 748751EF4B; Fri, 25 Sep 2020 03:06:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3B0B31E599 for ; Fri, 25 Sep 2020 03:06:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D655398300A; Fri, 25 Sep 2020 07:06:19 +0000 (GMT) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by sourceware.org (Postfix) with ESMTPS id 552233983013 for ; Fri, 25 Sep 2020 07:06:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 552233983013 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=saagarjha.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=saagarjha28@gmail.com Received: by mail-pj1-f65.google.com with SMTP id s14so949844pju.1 for ; Fri, 25 Sep 2020 00:06:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cgMSoEMUhFPaHWuMS5A7bHRPL5Yd8cQRm/hb4pxn9Ws=; b=LzpQChHFRxd9QjDdV4H7bNijUB/8xObHG5nLpHdRTw8HBVY24osibE4nUnVhPnRBCN IsNCLvfUFHlPIynbjRFUXjfqUxFWbeGt0CiFaoGOzy/JNdxQdYKNTBTHARVBNgZWO3N2 ke0Zz6PDWNEctkI5oEf1CbRxQ4qw6L8Glpr6ECaungWqFijwv0ZHBzLi22nYUHOyXyV4 lK/qXEzNMtesyBKG5FfRy3AAzprqcRhtxdIWfd0kKsiu06Bj7lwJ4J53Pk6RUcxkd/R5 crswkMkUpxle24zZKZUKS/yrSCYYdhD3Q/Gmch52OxKAp4SdR15JG91JbHvFiY5SdCaw Fcmw== X-Gm-Message-State: AOAM533P7L4BOtR+qcbOTky+9NeUqZ+UB002G+vJC56F01HBruJ1zR84 JQ9MEa7WNsP8OLG5n5qcQFZ+2PqU4y8= X-Google-Smtp-Source: ABdhPJyY9317Fo9pSDNnwPl8qiNqgaMHM3j53Q9eVbhp6lkan000L4R5TIu/EhOMReDj5FV0BZmz8A== X-Received: by 2002:a17:90a:db49:: with SMTP id u9mr1371194pjx.90.1601017575823; Fri, 25 Sep 2020 00:06:15 -0700 (PDT) Received: from localhost.localdomain ([73.92.124.25]) by smtp.gmail.com with ESMTPSA id c1sm1545196pfj.219.2020.09.25.00.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 00:06:15 -0700 (PDT) From: Saagar Jha To: gdb-patches@sourceware.org Subject: [PATCH] Add a missing munmap_list move constructor Date: Fri, 25 Sep 2020 00:05:24 -0700 Message-Id: <20200925070525.47993-1-saagar@saagarjha.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <883A80DB-0918-4BA6-B387-A54581BFEA42@saagarjha.com> References: <883A80DB-0918-4BA6-B387-A54581BFEA42@saagarjha.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Saagar Jha Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" compile_module attempts to request a move constructor, but because munmap_list doesn't have one it gets implicitly deleted. This is an warning on clang under -Wdefaulted-function-deleted (which is enabled by default): In file included from compile/compile-object-load.c:21: compile/compile-object-load.h:56:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] compile_module (compile_module &&other) = default; ^ compile/compile-object-load.h:86:22: note: move constructor of 'compile_module' is implicitly deleted because field 'munmap_list' has a deleted move constructor struct munmap_list munmap_list; ^ compile/compile-object-load.h:30:28: note: 'munmap_list' has been explicitly marked deleted here DISABLE_COPY_AND_ASSIGN (munmap_list); ^ gdb/ChangeLog: * compile/compile-object-load.h: Give munmap_list a move constructor. --- gdb/ChangeLog | 5 +++++ gdb/compile/compile-object-load.h | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3872a8d9cb..043c6a4c72 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-09-25 Saagar Jha + + * compile/compile-object-load.h: Give munmap_list a move + constructor. + 2020-09-24 Tom Tromey PR tui/26638: diff --git a/gdb/compile/compile-object-load.h b/gdb/compile/compile-object-load.h index 0254390109..166d442ad0 100644 --- a/gdb/compile/compile-object-load.h +++ b/gdb/compile/compile-object-load.h @@ -30,6 +30,7 @@ struct munmap_list DISABLE_COPY_AND_ASSIGN (munmap_list); munmap_list &operator= (munmap_list &&) = default; + munmap_list (munmap_list &&) = default; /* Add a region to the list. */ void add (CORE_ADDR addr, CORE_ADDR size); -- 2.28.0