From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4SplDv8sbF+FcQAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 01:22:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 2B1E71EE05; Thu, 24 Sep 2020 01:22:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 729A21E599 for ; Thu, 24 Sep 2020 01:22:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E9BB3857C4F; Thu, 24 Sep 2020 05:22:05 +0000 (GMT) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by sourceware.org (Postfix) with ESMTPS id ED0753857C4F for ; Thu, 24 Sep 2020 05:22:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ED0753857C4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=saagarjha.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=saagarjha28@gmail.com Received: by mail-pl1-f169.google.com with SMTP id y6so1035561plt.9 for ; Wed, 23 Sep 2020 22:22:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=4va4zyHESbGNKF8bBhPXrpvry5qI8KXMf8ewBszVw0U=; b=VN1pNbXFktjRP7Xg2Vypx5zBekUuqffPHc64ZG2GxDs+4XIarcIjTbBBtGIVesqC7L 66JUYgmUhmVL4zmbjw0FgKKUsLLozfHXr8SEASGmFPAqBDDTt57c/wECEi53GoubNaaW YFSYbLXe+w7+bK1LbU/gj9PEo6Gi1EYHq4l3hP1l52SHSm+60SNBy0CP3Yj126yIxQDm HrkfxiqqG5FatNr1Lgb7a1cb1UekPl1xqsgLnlesNvRkUXTO+q2WeJkuFP6UldVo40YC 2krd4sG//hGpEt06lKXgJusipndE3hY8KcsB5/Ln1gISkQHS3+cWfdl5rZ0kBrfy5NGB AsbA== X-Gm-Message-State: AOAM531d3KSxnlFv5RKY8k32smXIK3iNvEshM1LzenBiwF2OwpC/FMEC F5viNiavKoEFQysN0nlURZ6uVBA4DY0= X-Google-Smtp-Source: ABdhPJy7CdxN64WmiOKoFk48/Kyqf25k2+q5poJ3JHMKni/09KLJBMU4uI+mMsE9b2vRt4lncLj5lA== X-Received: by 2002:a17:90b:80f:: with SMTP id bk15mr2518757pjb.36.1600924921842; Wed, 23 Sep 2020 22:22:01 -0700 (PDT) Received: from localhost.localdomain (c-73-92-124-25.hsd1.ca.comcast.net. [73.92.124.25]) by smtp.gmail.com with ESMTPSA id e17sm1327968pff.6.2020.09.23.22.22.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Sep 2020 22:22:01 -0700 (PDT) From: Saagar Jha Content-Type: multipart/mixed; boundary="Apple-Mail=_D9CA50FD-1F35-4865-8CB3-683899CB418E" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.0.3.2.33\)) Subject: [PATCH] Add a missing munmap_list move constructor Message-Id: <58351270-2804-4A48-ABA5-2589312C06B6@saagarjha.com> Date: Wed, 23 Sep 2020 22:22:00 -0700 To: gdb-patches@sourceware.org X-Mailer: Apple Mail (2.3654.0.3.2.33) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --Apple-Mail=_D9CA50FD-1F35-4865-8CB3-683899CB418E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Clang warns if the default implementation of a function is requested but = it is implicitly deleted. This was happening to compile_module because = it didn=E2=80=99t have a move constructor for its munmap_list member, so = I went ahead and added one since it already had a move assignment = operator defined for it and this seemed like an oversight. --Apple-Mail=_D9CA50FD-1F35-4865-8CB3-683899CB418E Content-Disposition: attachment; filename=Add-a-missing-munmap_list-move-constructor.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="Add-a-missing-munmap_list-move-constructor.patch" Content-Transfer-Encoding: quoted-printable =46rom=203ed7e54dfc5b3ab0a6033a239f8d6a457cb91f92=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Saagar=20Jha=20=0ADate:=20= Wed,=2023=20Sep=202020=2022:16:17=20-0700=0ASubject:=20[PATCH]=20Add=20a=20= missing=20munmap_list=20move=20constructor=0A=0Acompile_module=20= attempts=20to=20request=20a=20move=20constructor,=20but=20because=0A= munmap_list=20doesn't=20have=20one=20it=20gets=20implicitly=20deleted.=20= This=20is=20an=0Awarning=20on=20clang=20under=20= -Wdefaulted-function-deleted=20(which=20is=20enabled=20by=0Adefault).=0A=0A= gdb/ChangeLog:=0A=0A=09*=20compile/compile-object-load.h:=20Give=20= munmap_list=20a=20move=0A=09constructor.=0A---=0A=20gdb/ChangeLog=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=205=20+++++=0A=20= gdb/compile/compile-object-load.h=20|=201=20+=0A=202=20files=20changed,=20= 6=20insertions(+)=0A=0Adiff=20--git=20a/gdb/ChangeLog=20b/gdb/ChangeLog=0A= index=20241f3e7027..3aa3255b37=20100644=0A---=20a/gdb/ChangeLog=0A+++=20= b/gdb/ChangeLog=0A@@=20-1,3=20+1,8=20@@=0A+2020-09-23=20=20Saagar=20Jha=20= =20=0A+=0A+=09*=20compile/compile-object-load.h:=20= Give=20munmap_list=20a=20move=0A+=09constructor.=0A+=0A=202020-09-23=20=20= Tom=20Tromey=20=20=0A=20=0A=20=09PR=20symtab/25470:=0A= diff=20--git=20a/gdb/compile/compile-object-load.h=20= b/gdb/compile/compile-object-load.h=0Aindex=200254390109..166d442ad0=20= 100644=0A---=20a/gdb/compile/compile-object-load.h=0A+++=20= b/gdb/compile/compile-object-load.h=0A@@=20-30,6=20+30,7=20@@=20struct=20= munmap_list=0A=20=20=20DISABLE_COPY_AND_ASSIGN=20(munmap_list);=0A=20=0A=20= =20=20munmap_list=20&operator=3D=20(munmap_list=20&&)=20=3D=20default;=0A= +=20=20munmap_list=20(munmap_list=20&&)=20=3D=20default;=0A=20=0A=20=20=20= /*=20Add=20a=20region=20to=20the=20list.=20=20*/=0A=20=20=20void=20add=20= (CORE_ADDR=20addr,=20CORE_ADDR=20size);=0A--=20=0A2.28.0=0A=0A= --Apple-Mail=_D9CA50FD-1F35-4865-8CB3-683899CB418E--