From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>, Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/8] Add self-test framework to gdb
Date: Fri, 29 Apr 2016 20:54:00 -0000 [thread overview]
Message-ID: <5723CA00.5090607@ericsson.com> (raw)
In-Reply-To: <87wpngqhcq.fsf@tromey.com>
On 16-04-29 04:40 PM, Tom Tromey wrote:
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 400d2b0..c99bca6 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -869,8 +869,10 @@ SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \
> proc-service.list progspace.c \
> prologue-value.c psymtab.c \
> regcache.c reggroups.c remote.c remote-fileio.c remote-notif.c reverse.c \
> - sentinel-frame.c \
> + selftest.c sentinel-frame.c \
> serial.c ser-base.c ser-unix.c ser-event.c skip.c \
> + selftest.c sentinel-frame.c \
> + serial.c ser-base.c ser-unix.c skip.c \
I think that some filenames/lines end up duplicated here.
May I suggest that in the future, we add each filename on its own line
in those lists? Not only does it make it easier to add files in the
middle of the list, it also makes diffs much clearer.
next prev parent reply other threads:[~2016-04-29 20:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 20:35 [PATCH v2 0/8] Add Rust language support Tom Tromey
2016-04-27 20:35 ` [PATCH v2 2/8] Make gdb expression debugging handle OP_F90_RANGE Tom Tromey
2016-04-27 20:35 ` [PATCH v2 7/8] Add Rust documentation Tom Tromey
2016-04-28 4:59 ` Eli Zaretskii
2016-04-27 20:35 ` [PATCH v2 8/8] Rename OP_F90_RANGE to OP_RANGE Tom Tromey
2016-04-27 21:26 ` Pedro Alves
2016-04-27 20:35 ` [PATCH v2 4/8] Add array start and end strings to generic_val_print_decorations Tom Tromey
2016-04-27 20:35 ` [PATCH v2 6/8] Update gdb test suite for Rust Tom Tromey
2016-04-27 20:35 ` [PATCH v2 1/8] Fix latent yacc-related bug in gdb/Makefile.in init.c rule Tom Tromey
2016-04-27 20:35 ` [PATCH v2 3/8] Add self-test framework to gdb Tom Tromey
2016-04-28 5:00 ` Eli Zaretskii
2016-04-28 10:28 ` Yao Qi
2016-04-29 15:13 ` Tom Tromey
2016-04-29 15:29 ` Yao Qi
2016-04-29 17:29 ` Doug Evans
2016-04-29 20:40 ` Tom Tromey
2016-04-29 20:54 ` Simon Marchi [this message]
2016-04-29 21:09 ` Tom Tromey
2016-05-03 15:58 ` Yao Qi
2016-04-27 20:36 ` [PATCH v2 5/8] Add support for the Rust language Tom Tromey
2016-04-27 21:27 ` [PATCH v2 0/8] Add Rust language support Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5723CA00.5090607@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox