From: Doug Evans <dje@google.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/8] Add self-test framework to gdb
Date: Fri, 29 Apr 2016 17:29:00 -0000 [thread overview]
Message-ID: <CADPb22TJW2JqdZRkpspKMCTaL1FMZ_+7pkiuuT-2sDWxjfk9DA@mail.gmail.com> (raw)
In-Reply-To: <868tzwe8n7.fsf@gmail.com>
On Fri, Apr 29, 2016 at 8:29 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Tom Tromey <tom@tromey.com> writes:
>
>> It would also be possible to use exceptions rather than asserts.
>> Then the current single command could be kept, since gdb wouldn't abort
>> on failure.
>>
>> Let me know which you'd prefer.
>
> Using exceptions is fine to me.
On a separate note, where do we, in the long term, want tests to live?
I'm wondering about the scalability of having tests in the same source file
reducing the readability, and whether we want conventions to avoid this.
I'm not saying 100% of tests have to, say, live in separate files
(e.g. foo.c tests -> foo-test.c or some such).
I'm just paranoid about having a repeat of the massive readability reduction
from the adding of record support to *-tdep.c files.
[Imagine how the sources will look 5 years from now.]
next prev parent reply other threads:[~2016-04-29 17:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 20:35 [PATCH v2 0/8] Add Rust language support Tom Tromey
2016-04-27 20:35 ` [PATCH v2 2/8] Make gdb expression debugging handle OP_F90_RANGE Tom Tromey
2016-04-27 20:35 ` [PATCH v2 7/8] Add Rust documentation Tom Tromey
2016-04-28 4:59 ` Eli Zaretskii
2016-04-27 20:35 ` [PATCH v2 4/8] Add array start and end strings to generic_val_print_decorations Tom Tromey
2016-04-27 20:35 ` [PATCH v2 8/8] Rename OP_F90_RANGE to OP_RANGE Tom Tromey
2016-04-27 21:26 ` Pedro Alves
2016-04-27 20:35 ` [PATCH v2 3/8] Add self-test framework to gdb Tom Tromey
2016-04-28 5:00 ` Eli Zaretskii
2016-04-28 10:28 ` Yao Qi
2016-04-29 15:13 ` Tom Tromey
2016-04-29 15:29 ` Yao Qi
2016-04-29 17:29 ` Doug Evans [this message]
2016-04-29 20:40 ` Tom Tromey
2016-04-29 20:54 ` Simon Marchi
2016-04-29 21:09 ` Tom Tromey
2016-05-03 15:58 ` Yao Qi
2016-04-27 20:35 ` [PATCH v2 6/8] Update gdb test suite for Rust Tom Tromey
2016-04-27 20:35 ` [PATCH v2 1/8] Fix latent yacc-related bug in gdb/Makefile.in init.c rule Tom Tromey
2016-04-27 20:36 ` [PATCH v2 5/8] Add support for the Rust language Tom Tromey
2016-04-27 21:27 ` [PATCH v2 0/8] Add Rust language support Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TJW2JqdZRkpspKMCTaL1FMZ_+7pkiuuT-2sDWxjfk9DA@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox