From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19368 invoked by alias); 29 Apr 2016 20:54:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19359 invoked by uid 89); 29 Apr 2016 20:54:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 29 Apr 2016 20:54:27 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 87.CD.03614.4D9C3275; Fri, 29 Apr 2016 22:53:40 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Fri, 29 Apr 2016 16:54:24 -0400 Subject: Re: [PATCH v2 3/8] Add self-test framework to gdb To: Tom Tromey , Yao Qi References: <1461789279-15996-1-git-send-email-tom@tromey.com> <1461789279-15996-4-git-send-email-tom@tromey.com> <86wpnido3w.fsf@gmail.com> <877ffgbg8h.fsf@tromey.com> <868tzwe8n7.fsf@gmail.com> <87wpngqhcq.fsf@tromey.com> CC: From: Simon Marchi Message-ID: <5723CA00.5090607@ericsson.com> Date: Fri, 29 Apr 2016 20:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87wpngqhcq.fsf@tromey.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00662.txt.bz2 On 16-04-29 04:40 PM, Tom Tromey wrote: > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 400d2b0..c99bca6 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -869,8 +869,10 @@ SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \ > proc-service.list progspace.c \ > prologue-value.c psymtab.c \ > regcache.c reggroups.c remote.c remote-fileio.c remote-notif.c reverse.c \ > - sentinel-frame.c \ > + selftest.c sentinel-frame.c \ > serial.c ser-base.c ser-unix.c ser-event.c skip.c \ > + selftest.c sentinel-frame.c \ > + serial.c ser-base.c ser-unix.c skip.c \ I think that some filenames/lines end up duplicated here. May I suggest that in the future, we add each filename on its own line in those lists? Not only does it make it easier to add files in the middle of the list, it also makes diffs much clearer.