From: Ruslan Kabatsayev <b7.10110111@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
Date: Fri, 04 Dec 2015 14:41:00 -0000 [thread overview]
Message-ID: <5661A654.5090808@gmail.com> (raw)
In-Reply-To: <86610fu60p.fsf@gmail.com>
On 12/03/2015 02:27 PM, Yao Qi wrote:
> Thanks for running the test. Could you test your patch against GDB git
> mainline please? The patch will be applied to mainline, so we need to
> test it against mainline.
With current git master the result is the same: no noticeable changes between patched and unpatched version.
>> # of expected passes 32377
>> # of unexpected failures 85
>> # of unexpected successes 2
>> # of expected failures 72
>> # of unknown successes 2
>> # of known failures 62
>> # of untested testcases 36
>> # of unsupported tests 201
>>
>> And here's after my patch:
>>
>> # of expected passes 32378
>> # of unexpected failures 85
>> # of unexpected successes 2
>> # of expected failures 71
>> # of unknown successes 2
>> # of known failures 62
>> # of untested testcases 36
>> # of unsupported tests 201
>>
>> I.e. one "expected failure" less and one "expected pass" more. I'm not
>> sure how to interpret this result.
>>
> This may happen from time to time, especially in some gdb.threads tests.
For some reason such things happen with different individual tests almost on
every `make check` here, be it patched or unpatched version.
>>>> gdb/ChangeLog:
>>>>
>>>> * configure.host: Fix detection of x86_64 host when setting
>>>> floatformats
>>> This line is too long, the max is 74. Sentence should be ended with ".".
>> Should I resend the whole original mail with this fixed?
> Please post the changelog entry only for the reference.
gdb/ChangeLog:
* configure.host: Fix detection of x86_64 host when setting
floatformats.
> If there is no regression in the GDB mainline tests, and no objections
> from other people in 3 days, your patch can go in.
>
> Do you have write access to git repository and FSF copyright assignment?
> If you don't have them, I can commit it for you as a tiny patch.
> However, if you want to contribute more patches, you need an FSF
> copyright assignment, and git write access, so that you can push by yourself.
I think I don't. How do I get them?
As for more patches, I'm going to make a regression test for this fix, as
suggested by Pedro Alves in another email.
next prev parent reply other threads:[~2015-12-04 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 22:07 Ruslan Kabatsayev
2015-12-02 11:32 ` Yao Qi
2015-12-02 14:26 ` Ruslan Kabatsayev
2015-12-03 11:27 ` Yao Qi
2015-12-04 14:41 ` Ruslan Kabatsayev [this message]
2015-12-03 12:28 ` Pedro Alves
2015-12-04 15:06 ` Ruslan Kabatsayev
2015-12-04 15:11 ` Pedro Alves
2015-12-04 15:17 ` Ruslan Kabatsayev
2015-12-04 15:35 ` Pedro Alves
2015-12-04 16:09 ` Ruslan Kabatsayev
2015-12-05 22:41 ` Andrew Burgess
2015-12-06 6:30 ` Ruslan Kabatsayev
2015-12-09 12:23 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5661A654.5090808@gmail.com \
--to=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox