Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Ruslan Kabatsayev <b7.10110111@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
Date: Thu, 03 Dec 2015 12:28:00 -0000	[thread overview]
Message-ID: <5660357F.4030605@redhat.com> (raw)
In-Reply-To: <564F998D.5080406@gmail.com>

On 11/20/2015 10:07 PM, Ruslan Kabatsayev wrote:
> When `info float` is used on an AMD64 system, GDB prints floating-point
> values of x87 registers with raw contents like 0x361a867a8e0527397ce0 or
> 0xc4f988454a1ddd3cfdab wrongly. This happens due to truncation to double,
> after which the former becomes 0.0, and the latter becomes negative infinity.
> This is caused by failed detection of x86-64 host, which results in setting
> gdb_host_{float,double,long_double}_format to zeros.
> This commit fixes this misdetection.

A test to make sure we don't regress this would be nice.
Maybe add something to gdb.arch/i386-float.exp ?

Thanks,
Pedro Alves


  parent reply	other threads:[~2015-12-03 12:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 22:07 Ruslan Kabatsayev
2015-12-02 11:32 ` Yao Qi
2015-12-02 14:26   ` Ruslan Kabatsayev
2015-12-03 11:27     ` Yao Qi
2015-12-04 14:41       ` Ruslan Kabatsayev
2015-12-03 12:28 ` Pedro Alves [this message]
2015-12-04 15:06   ` Ruslan Kabatsayev
2015-12-04 15:11     ` Pedro Alves
2015-12-04 15:17       ` Ruslan Kabatsayev
2015-12-04 15:35         ` Pedro Alves
2015-12-04 16:09           ` Ruslan Kabatsayev
2015-12-05 22:41             ` Andrew Burgess
2015-12-06  6:30               ` Ruslan Kabatsayev
2015-12-09 12:23                 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5660357F.4030605@redhat.com \
    --to=palves@redhat.com \
    --cc=b7.10110111@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox