From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66004 invoked by alias); 4 Dec 2015 14:41:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65262 invoked by uid 89); 4 Dec 2015 14:41:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lf0-f46.google.com Received: from mail-lf0-f46.google.com (HELO mail-lf0-f46.google.com) (209.85.215.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 04 Dec 2015 14:41:43 +0000 Received: by lfdl133 with SMTP id l133so112792648lfd.2 for ; Fri, 04 Dec 2015 06:41:40 -0800 (PST) X-Received: by 10.25.209.148 with SMTP id i142mr8500005lfg.163.1449240100040; Fri, 04 Dec 2015 06:41:40 -0800 (PST) Received: from [192.168.18.151] ([81.222.86.72]) by smtp.gmail.com with ESMTPSA id j189sm2361481lfg.46.2015.12.04.06.41.39 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 06:41:39 -0800 (PST) Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64 To: Yao Qi References: <564F998D.5080406@gmail.com> <86mvttt7be.fsf@gmail.com> <86610fu60p.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Ruslan Kabatsayev Message-ID: <5661A654.5090808@gmail.com> Date: Fri, 04 Dec 2015 14:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <86610fu60p.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00079.txt.bz2 On 12/03/2015 02:27 PM, Yao Qi wrote: > Thanks for running the test. Could you test your patch against GDB git > mainline please? The patch will be applied to mainline, so we need to > test it against mainline. With current git master the result is the same: no noticeable changes between patched and unpatched version. >> # of expected passes 32377 >> # of unexpected failures 85 >> # of unexpected successes 2 >> # of expected failures 72 >> # of unknown successes 2 >> # of known failures 62 >> # of untested testcases 36 >> # of unsupported tests 201 >> >> And here's after my patch: >> >> # of expected passes 32378 >> # of unexpected failures 85 >> # of unexpected successes 2 >> # of expected failures 71 >> # of unknown successes 2 >> # of known failures 62 >> # of untested testcases 36 >> # of unsupported tests 201 >> >> I.e. one "expected failure" less and one "expected pass" more. I'm not >> sure how to interpret this result. >> > This may happen from time to time, especially in some gdb.threads tests. For some reason such things happen with different individual tests almost on every `make check` here, be it patched or unpatched version. >>>> gdb/ChangeLog: >>>> >>>> * configure.host: Fix detection of x86_64 host when setting >>>> floatformats >>> This line is too long, the max is 74. Sentence should be ended with ".". >> Should I resend the whole original mail with this fixed? > Please post the changelog entry only for the reference. gdb/ChangeLog: * configure.host: Fix detection of x86_64 host when setting floatformats. > If there is no regression in the GDB mainline tests, and no objections > from other people in 3 days, your patch can go in. > > Do you have write access to git repository and FSF copyright assignment? > If you don't have them, I can commit it for you as a tiny patch. > However, if you want to contribute more patches, you need an FSF > copyright assignment, and git write access, so that you can push by yourself. I think I don't. How do I get them? As for more patches, I'm going to make a regression test for this fix, as suggested by Pedro Alves in another email.