Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 0/6] Support software single step and conditional breakpoints on ARM in GDBServer.
Date: Wed, 02 Dec 2015 13:52:00 -0000	[thread overview]
Message-ID: <565EF787.9050300@ericsson.com> (raw)
In-Reply-To: <565EF3EF.4080009@redhat.com>



On 12/02/2015 08:36 AM, Pedro Alves wrote:
> On 12/02/2015 01:17 PM, Antoine Tremblay wrote:
>> In this v4:
>>
>> Patches [1-5] of the v3 have been pushed in.
>>
>> A new patch 3 is now introduced to refactor arm_software_single_step to
>> use regcache instead of frame so that we can share the registry reading
>> function regcache_raw_read_unsigned between GDB and GDBServer.
>>
>> This allows the removal of the operation collect_register_unsigned from
>> the get_next_pcs context structure.
>>
>> Patch 1: is OK.
>> Patch 2: is OK.
>> Patch 3: New patch needs review.
>> Patch 4: Needs review. This was adapted based on the new patch 3.
>> Patch 5: is OK.
>> Patch 6: is OK.
>
> Is the syscall issue fixed in this version?
>

Yes sorry amazingly I forgot to add this to the comment log.

Patch 4 comment is updated to remove the limitation, however.

Regards,
Antoine


      reply	other threads:[~2015-12-02 13:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 13:18 Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 1/6] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 2/6] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 5/6] Enable software single stepping for while-stepping actions in GDBServer Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 3/6] Refactor arm_software_single_step to use regcache Antoine Tremblay
2015-12-03 10:28   ` Yao Qi
2015-12-03 13:11     ` Antoine Tremblay
2015-12-03 14:37       ` Yao Qi
2015-12-03 14:41         ` Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 6/6] Enable conditional breakpoints for targets that support software single step in GDBServer Antoine Tremblay
2015-12-02 13:19 ` [PATCH v4 4/6] Support software single step on ARM " Antoine Tremblay
2015-12-03 11:17   ` Yao Qi
2015-12-03 13:58     ` Antoine Tremblay
2015-12-03 14:49       ` Yao Qi
2015-12-02 13:36 ` [PATCH v4 0/6] Support software single step and conditional breakpoints " Pedro Alves
2015-12-02 13:52   ` Antoine Tremblay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565EF787.9050300@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox