Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>
Subject: [PATCH v4 6/6] Enable conditional breakpoints for targets that support software single step in GDBServer.
Date: Wed, 02 Dec 2015 13:18:00 -0000	[thread overview]
Message-ID: <1449062264-18565-7-git-send-email-antoine.tremblay@ericsson.com> (raw)
In-Reply-To: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com>

This patch enables support for conditional breakpoints if the target supports
software single step.

This was disabled before as the implementations of software single step were too
simple as discussed in
https://sourceware.org/ml/gdb-patches/2015-04/msg01110.html.

Since these issues are now fixed support can be added back.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:

	* server.c (handle_query): Call target_supports_software_single_step.
---
 gdb/gdbserver/server.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index 5e053b3..728d842 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -2290,13 +2290,9 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
 	  strcat (own_buf, ";tracenz+");
 	}
 
-      if (target_supports_hardware_single_step ())
+      if (target_supports_hardware_single_step ()
+	  || target_supports_software_single_step () )
 	{
-	  /* Support target-side breakpoint conditions and commands.
-	     GDBserver needs to step over the breakpoint if the condition
-	     is false.  GDBserver software single step is too simple, so
-	     disable conditional breakpoints if the target doesn't have
-	     hardware single step.  */
 	  strcat (own_buf, ";ConditionalBreakpoints+");
 	}
       strcat (own_buf, ";BreakpointCommands+");
-- 
2.6.3


  parent reply	other threads:[~2015-12-02 13:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 13:18 [PATCH v4 0/6] Support software single step and conditional breakpoints on ARM " Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 1/6] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 2/6] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 5/6] Enable software single stepping for while-stepping actions in GDBServer Antoine Tremblay
2015-12-02 13:18 ` [PATCH v4 3/6] Refactor arm_software_single_step to use regcache Antoine Tremblay
2015-12-03 10:28   ` Yao Qi
2015-12-03 13:11     ` Antoine Tremblay
2015-12-03 14:37       ` Yao Qi
2015-12-03 14:41         ` Antoine Tremblay
2015-12-02 13:18 ` Antoine Tremblay [this message]
2015-12-02 13:19 ` [PATCH v4 4/6] Support software single step on ARM in GDBServer Antoine Tremblay
2015-12-03 11:17   ` Yao Qi
2015-12-03 13:58     ` Antoine Tremblay
2015-12-03 14:49       ` Yao Qi
2015-12-02 13:36 ` [PATCH v4 0/6] Support software single step and conditional breakpoints " Pedro Alves
2015-12-02 13:52   ` Antoine Tremblay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449062264-18565-7-git-send-email-antoine.tremblay@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox