From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88414 invoked by alias); 2 Dec 2015 13:52:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87633 invoked by uid 89); 2 Dec 2015 13:52:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 02 Dec 2015 13:52:10 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 13.21.32102.587FE565; Wed, 2 Dec 2015 14:52:05 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Wed, 2 Dec 2015 08:52:07 -0500 Subject: Re: [PATCH v4 0/6] Support software single step and conditional breakpoints on ARM in GDBServer. To: Pedro Alves , References: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com> <565EF3EF.4080009@redhat.com> From: Antoine Tremblay Message-ID: <565EF787.9050300@ericsson.com> Date: Wed, 02 Dec 2015 13:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <565EF3EF.4080009@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00033.txt.bz2 On 12/02/2015 08:36 AM, Pedro Alves wrote: > On 12/02/2015 01:17 PM, Antoine Tremblay wrote: >> In this v4: >> >> Patches [1-5] of the v3 have been pushed in. >> >> A new patch 3 is now introduced to refactor arm_software_single_step to >> use regcache instead of frame so that we can share the registry reading >> function regcache_raw_read_unsigned between GDB and GDBServer. >> >> This allows the removal of the operation collect_register_unsigned from >> the get_next_pcs context structure. >> >> Patch 1: is OK. >> Patch 2: is OK. >> Patch 3: New patch needs review. >> Patch 4: Needs review. This was adapted based on the new patch 3. >> Patch 5: is OK. >> Patch 6: is OK. > > Is the syscall issue fixed in this version? > Yes sorry amazingly I forgot to add this to the comment log. Patch 4 comment is updated to remove the limitation, however. Regards, Antoine