From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/3] Constify thread name return path
Date: Thu, 26 Nov 2015 11:21:00 -0000 [thread overview]
Message-ID: <5656EB38.6080601@redhat.com> (raw)
In-Reply-To: <1448488138-2360-2-git-send-email-simon.marchi@ericsson.com>
On 11/25/2015 09:48 PM, Simon Marchi wrote:
> Since this code path returns a string owned by the target (we don't know how
> it's allocated, could be a static read-only string), it's safer if we return
> a constant string. If, for some reasons, the caller wishes to modify the
> string, it should make itself a copy.
>
> gdb/ChangeLog:
>
> * linux-nat.c (linux_nat_thread_name): Constify return value.
> * target.h (struct target_ops) <to_thread_name>: Likewise.
> (target_thread_name): Likewise.
> * target.c (target_thread_name): Likewise.
> * target-delegates.c (debug_thread_name): Regenerate.
> * python/py-infthread.c (thpy_get_name): Constify local variables.
> * thread.c (print_thread_info): Likewise.
> (thread_find_command): Likewise.
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-11-26 11:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 21:49 [PATCH v2 0/3] Remote thread name support Simon Marchi
2015-11-25 21:49 ` [PATCH v2 3/3] Add test for thread names Simon Marchi
2015-11-26 11:45 ` Pedro Alves
2015-11-26 16:00 ` Simon Marchi
2015-11-26 16:57 ` Pedro Alves
2015-11-26 18:21 ` Simon Marchi
2015-11-25 21:49 ` [PATCH v2 1/3] Constify thread name return path Simon Marchi
2015-11-26 11:21 ` Pedro Alves [this message]
2015-11-26 15:46 ` Simon Marchi
2015-11-25 21:49 ` [PATCH v2 2/3] Display names of remote threads Simon Marchi
2015-11-26 11:32 ` Pedro Alves
2015-11-26 15:52 ` Simon Marchi
2015-11-26 16:30 ` Pedro Alves
2015-11-26 17:00 ` Simon Marchi
2015-11-27 14:37 ` Yao Qi
2015-11-27 15:16 ` Simon Marchi
2015-12-01 17:08 ` [commit] Fix build error (Re: [PATCH v2 2/3] Display names of remote threads) Ulrich Weigand
2015-12-01 17:54 ` Simon Marchi
2015-11-27 13:31 ` gdb fails to build (was: Re: [PATCH v2 0/3] Remote thread name support) Tobias Burnus
2015-11-27 15:49 ` gdb fails to build Simon Marchi
2015-11-27 19:05 ` Simon Marchi
2015-11-27 22:36 ` Tobias Burnus
2015-11-27 22:47 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656EB38.6080601@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox