From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 2/3] Display names of remote threads
Date: Fri, 27 Nov 2015 14:37:00 -0000 [thread overview]
Message-ID: <86mvtzv78l.fsf@gmail.com> (raw)
In-Reply-To: <56572AA0.9070904@ericsson.com> (Simon Marchi's message of "Thu, 26 Nov 2015 10:52:00 -0500")
Simon Marchi <simon.marchi@ericsson.com> writes:
> + attr = xml_find_attribute (attributes, "name");
> + item.name = attr != NULL ? xstrdup (attr->value) : NULL;
> +
This breaks the C++ build,
/home/yao/SourceCode/gnu/gdb/git/gdb/remote.c: In function ‘void start_thread(gdb_xml_parser*, const gdb_xml_element*, void*, VEC_gdb_xml_value_s*)’:
/home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:2975:50: error: invalid conversion from ‘void*’ to ‘const char*’ [-fpermissive]
item.name = attr != NULL ? xstrdup (attr->value) : NULL;
^
In file included from /home/yao/SourceCode/gnu/gdb/git/gdb/common/common-defs.h:64:0,
from /home/yao/SourceCode/gnu/gdb/git/gdb/defs.h:28,
from /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:22:
/home/yao/SourceCode/gnu/gdb/git/gdb/../include/libiberty.h:323:14: note: initializing argument 1 of ‘char* xstrdup(const char*)’
extern char *xstrdup (const char *) ATTRIBUTE_MALLOC ATTRIBUTE_RETURNS_NONNULL;
and I think you've already received the mail from buildbot.
http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1413
--
Yao (齐尧)
next prev parent reply other threads:[~2015-11-27 14:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 21:49 [PATCH v2 0/3] Remote thread name support Simon Marchi
2015-11-25 21:49 ` [PATCH v2 3/3] Add test for thread names Simon Marchi
2015-11-26 11:45 ` Pedro Alves
2015-11-26 16:00 ` Simon Marchi
2015-11-26 16:57 ` Pedro Alves
2015-11-26 18:21 ` Simon Marchi
2015-11-25 21:49 ` [PATCH v2 2/3] Display names of remote threads Simon Marchi
2015-11-26 11:32 ` Pedro Alves
2015-11-26 15:52 ` Simon Marchi
2015-11-26 16:30 ` Pedro Alves
2015-11-26 17:00 ` Simon Marchi
2015-11-27 14:37 ` Yao Qi [this message]
2015-11-27 15:16 ` Simon Marchi
2015-12-01 17:08 ` [commit] Fix build error (Re: [PATCH v2 2/3] Display names of remote threads) Ulrich Weigand
2015-12-01 17:54 ` Simon Marchi
2015-11-25 21:49 ` [PATCH v2 1/3] Constify thread name return path Simon Marchi
2015-11-26 11:21 ` Pedro Alves
2015-11-26 15:46 ` Simon Marchi
2015-11-27 13:31 ` gdb fails to build (was: Re: [PATCH v2 0/3] Remote thread name support) Tobias Burnus
2015-11-27 15:49 ` gdb fails to build Simon Marchi
2015-11-27 19:05 ` Simon Marchi
2015-11-27 22:36 ` Tobias Burnus
2015-11-27 22:47 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mvtzv78l.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox