From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118210 invoked by alias); 26 Nov 2015 11:21:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116216 invoked by uid 89); 26 Nov 2015 11:21:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Nov 2015 11:21:31 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4C109146E69; Thu, 26 Nov 2015 11:21:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQBLScg029573; Thu, 26 Nov 2015 06:21:29 -0500 Message-ID: <5656EB38.6080601@redhat.com> Date: Thu, 26 Nov 2015 11:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/3] Constify thread name return path References: <1448488138-2360-1-git-send-email-simon.marchi@ericsson.com> <1448488138-2360-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1448488138-2360-2-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00546.txt.bz2 On 11/25/2015 09:48 PM, Simon Marchi wrote: > Since this code path returns a string owned by the target (we don't know how > it's allocated, could be a static read-only string), it's safer if we return > a constant string. If, for some reasons, the caller wishes to modify the > string, it should make itself a copy. > > gdb/ChangeLog: > > * linux-nat.c (linux_nat_thread_name): Constify return value. > * target.h (struct target_ops) : Likewise. > (target_thread_name): Likewise. > * target.c (target_thread_name): Likewise. > * target-delegates.c (debug_thread_name): Regenerate. > * python/py-infthread.c (thpy_get_name): Constify local variables. > * thread.c (print_thread_info): Likewise. > (thread_find_command): Likewise. OK. Thanks, Pedro Alves