From: Pedro Alves <palves@redhat.com>
To: Richard Henderson <rth@redhat.com>, gdb-patches@gcc.gnu.org
Subject: Re: [PATCH 0/3] Support for x86 segments as address classes
Date: Thu, 05 Nov 2015 11:21:00 -0000 [thread overview]
Message-ID: <563B3BA3.3070402@redhat.com> (raw)
In-Reply-To: <1446558190-13482-1-git-send-email-rth@redhat.com>
On 11/03/2015 01:43 PM, Richard Henderson wrote:
> The following gets 90% of the way there, but I'm stuck --
> address_to_pointer and pointer_to_address do not appear to
> have access to a regcache. And not just in the one level
> of the caller, but significantly farther back in the call
> stack too.
The first two patches look generally good to me. Though
you'll need to update the manual and NEWS as well to document
the new target feature. (Also, I know this is a WIP, but
note that in gdb we strive to have the rationale for changes
in the git commit logs.)
>
> Which begs the question of whether I've simply missed
> something in how to get hold of the current regcache?
get_current_frame / get_current_regcache ? If you can pass it down
through a couple layers, it's of course better.
Though I'm not sufficiently familiar with the address class
mechanisms be to sure I'm not pointing you in the
wrong direction. Ulrich, can you help?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-11-05 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 13:43 Richard Henderson
2015-11-03 13:43 ` [PATCH 2/3] Use register cache for x86_64 ps_get_thread_area Richard Henderson
2015-11-03 13:44 ` [PATCH 3/3] Segment support for x86_64, part 1 Richard Henderson
2015-11-03 13:44 ` [PATCH 1/3] Add amd64 registers fs_base and gs_base Richard Henderson
2015-11-05 11:21 ` Pedro Alves [this message]
2015-11-05 14:15 ` [PATCH 0/3] Support for x86 segments as address classes Richard Henderson
2015-11-18 18:18 ` Ulrich Weigand
2015-11-05 14:18 ` [PATCH 4/3] Segment support for x86_64, part 2 Richard Henderson
2015-11-27 14:34 ` [PATCH 0/3] Support for x86 segments as address classes Gary Benson
2016-04-19 14:23 ` Tedeschi, Walfred
2016-04-19 14:44 ` Richard Henderson
2016-04-19 14:47 ` Walfred Tedeschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B3BA3.3070402@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox