From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71495 invoked by alias); 5 Nov 2015 11:21:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71482 invoked by uid 89); 5 Nov 2015 11:21:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Nov 2015 11:21:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 43579935F4 for ; Thu, 5 Nov 2015 11:21:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA5BL7tv008560; Thu, 5 Nov 2015 06:21:08 -0500 Message-ID: <563B3BA3.3070402@redhat.com> Date: Thu, 05 Nov 2015 11:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Richard Henderson , gdb-patches@gcc.gnu.org Subject: Re: [PATCH 0/3] Support for x86 segments as address classes References: <1446558190-13482-1-git-send-email-rth@redhat.com> In-Reply-To: <1446558190-13482-1-git-send-email-rth@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00180.txt.bz2 On 11/03/2015 01:43 PM, Richard Henderson wrote: > The following gets 90% of the way there, but I'm stuck -- > address_to_pointer and pointer_to_address do not appear to > have access to a regcache. And not just in the one level > of the caller, but significantly farther back in the call > stack too. The first two patches look generally good to me. Though you'll need to update the manual and NEWS as well to document the new target feature. (Also, I know this is a WIP, but note that in gdb we strive to have the rationale for changes in the git commit logs.) > > Which begs the question of whether I've simply missed > something in how to get hold of the current regcache? get_current_frame / get_current_regcache ? If you can pass it down through a couple layers, it's of course better. Though I'm not sufficiently familiar with the address class mechanisms be to sure I'm not pointing you in the wrong direction. Ulrich, can you help? Thanks, Pedro Alves