From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/13] Use gdb_bfd_sections in more places
Date: Fri, 28 Aug 2020 13:14:31 -0400 [thread overview]
Message-ID: <55ad80db-01d8-f486-3c06-726ccf48c6b8@simark.ca> (raw)
In-Reply-To: <20200828162349.987-1-tom@tromey.com>
On 2020-08-28 12:23 p.m., Tom Tromey wrote:
> As promised, here are some patches to use gdb_bfd_sections in more
> places.
>
> The main motivation for this patch is that ordinary iteration is
> easier to understand than callback functions. Often, it is also
> shorter -- some patches in this series remove helper functions or
> helper data structures. Finally, iteration is more type-safe (at
> least without additional wrappers to pass function-views through
> bfd_map_over_sections).
>
> I did not convert every call to bfd_map_over_sections. Some of the
> remaining calls are not easy to test. For the calls in compile/, I
> have another series that makes many changes in that code, and so I
> didn't want to introduce clashes at this time. (I don't recall
> offhand if that series fixes this, but I can revisit when it lands.)
>
> As usual with these cleanups, I don't plan to commit this until the
> release branch is made.
>
> Let me know what you think.
>
> Tom
>
>
Woohoo, thanks!
Apart from the small nits I sent, this all LGTM.
Simon
next prev parent reply other threads:[~2020-08-28 17:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 16:23 Tom Tromey
2020-08-28 16:23 ` [PATCH 01/13] Add a new overload of gdb_bfd_sections Tom Tromey
2020-08-28 16:34 ` Simon Marchi
2020-08-28 19:25 ` Tom Tromey
2020-08-28 16:23 ` [PATCH 02/13] Use gdb_bfd_sections in core_target_open Tom Tromey
2020-08-28 16:23 ` [PATCH 03/13] Use gdb_bfd_sections in gdb_bfd_close_or_warn Tom Tromey
2020-08-28 16:23 ` [PATCH 04/13] Use gdb_bfd_sections in get_stap_base_address Tom Tromey
2020-08-28 17:06 ` Simon Marchi
2020-08-28 16:23 ` [PATCH 05/13] Use gdb_bfd_sections in build_objfile_section_table Tom Tromey
2020-08-28 16:23 ` [PATCH 06/13] Use gdb_bfd_sections in symfile.c Tom Tromey
2020-08-28 17:00 ` Simon Marchi
2020-08-28 17:06 ` Simon Marchi
2020-08-28 16:23 ` [PATCH 07/13] Use gdb_bfd_sections in dwarf2/read.c Tom Tromey
2020-08-28 16:23 ` [PATCH 08/13] Use gdb_bfd_sections in ELF osabi tag sniffing Tom Tromey
2020-08-28 16:23 ` [PATCH 09/13] Use gdb_bfd_sections in gcore_memory_sections Tom Tromey
2020-08-28 16:23 ` [PATCH 10/13] Use gdb_bfd_sections in restore_command Tom Tromey
2020-08-28 17:12 ` Simon Marchi
2020-08-29 15:47 ` Tom Tromey
2020-08-29 15:49 ` Simon Marchi
2020-08-28 16:23 ` [PATCH 11/13] Use gdb_bfd_sections in elf_symfile_read Tom Tromey
2020-08-28 16:23 ` [PATCH 12/13] Use gdb_bfd_sections in build_section_table Tom Tromey
2020-08-28 16:23 ` [PATCH 13/13] Use gdb_bfd_sections in generic_load Tom Tromey
2020-08-28 17:14 ` Simon Marchi [this message]
2020-08-31 18:19 ` [PATCH 00/13] Use gdb_bfd_sections in more places John Baldwin
2020-09-19 18:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ad80db-01d8-f486-3c06-726ccf48c6b8@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox