From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E6658394BE1E for ; Fri, 28 Aug 2020 17:14:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E6658394BE1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2C06F1E599; Fri, 28 Aug 2020 13:14:33 -0400 (EDT) Subject: Re: [PATCH 00/13] Use gdb_bfd_sections in more places To: Tom Tromey , gdb-patches@sourceware.org References: <20200828162349.987-1-tom@tromey.com> From: Simon Marchi Message-ID: <55ad80db-01d8-f486-3c06-726ccf48c6b8@simark.ca> Date: Fri, 28 Aug 2020 13:14:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200828162349.987-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 17:14:35 -0000 On 2020-08-28 12:23 p.m., Tom Tromey wrote: > As promised, here are some patches to use gdb_bfd_sections in more > places. > > The main motivation for this patch is that ordinary iteration is > easier to understand than callback functions. Often, it is also > shorter -- some patches in this series remove helper functions or > helper data structures. Finally, iteration is more type-safe (at > least without additional wrappers to pass function-views through > bfd_map_over_sections). > > I did not convert every call to bfd_map_over_sections. Some of the > remaining calls are not easy to test. For the calls in compile/, I > have another series that makes many changes in that code, and so I > didn't want to introduce clashes at this time. (I don't recall > offhand if that series fixes this, but I can revisit when it lands.) > > As usual with these cleanups, I don't plan to commit this until the > release branch is made. > > Let me know what you think. > > Tom > > Woohoo, thanks! Apart from the small nits I sent, this all LGTM. Simon