From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 01/13] Add a new overload of gdb_bfd_sections
Date: Fri, 28 Aug 2020 12:34:10 -0400 [thread overview]
Message-ID: <7023e3ad-0200-9eaa-4a77-191b1cc5f567@simark.ca> (raw)
In-Reply-To: <20200828162349.987-2-tom@tromey.com>
On 2020-08-28 12:23 p.m., Tom Tromey wrote:
> This adds a new overload of gdb_bfd_sections, that accepts a
> gdb_bfd_ref_ptr. This also fixes the formatting of the existing
> function, since I happened to notice it was mildly off.
Ah thanks for fixing the formatting. I'm confusing different styles for
different code bases I'm working with at the moment :).
>
> gdb/ChangeLog
> 2020-08-28 Tom Tromey <tom@tromey.com>
>
> * gdb_bfd.h (gdb_bfd_sections): New overload. Fix formatting of
> existing function.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/gdb_bfd.h | 10 ++++++++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/gdb_bfd.h b/gdb/gdb_bfd.h
> index 0f450567d50..12330970873 100644
> --- a/gdb/gdb_bfd.h
> +++ b/gdb/gdb_bfd.h
> @@ -205,10 +205,16 @@ bool gdb_bfd_get_full_section_contents (bfd *abfd, asection *section,
> using gdb_bfd_section_iterator = next_iterator<asection>;
> using gdb_bfd_section_range = next_adapter<asection, gdb_bfd_section_iterator>;
>
> -static inline
> -gdb_bfd_section_range gdb_bfd_sections (bfd *abfd)
> +static inline gdb_bfd_section_range
> +gdb_bfd_sections (bfd *abfd)
> {
> return gdb_bfd_section_range (abfd->sections);
> }
>
> +static inline gdb_bfd_section_range
> +gdb_bfd_sections (const gdb_bfd_ref_ptr &abfd)
> +{
> + return gdb_bfd_section_range (abfd->sections);
> +};
> +
Just to confirm, the point of this is to avoid having to do `.get ()` everywhere?
(it LGTM)
Simon
next prev parent reply other threads:[~2020-08-28 16:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 16:23 [PATCH 00/13] Use gdb_bfd_sections in more places Tom Tromey
2020-08-28 16:23 ` [PATCH 01/13] Add a new overload of gdb_bfd_sections Tom Tromey
2020-08-28 16:34 ` Simon Marchi [this message]
2020-08-28 19:25 ` Tom Tromey
2020-08-28 16:23 ` [PATCH 02/13] Use gdb_bfd_sections in core_target_open Tom Tromey
2020-08-28 16:23 ` [PATCH 03/13] Use gdb_bfd_sections in gdb_bfd_close_or_warn Tom Tromey
2020-08-28 16:23 ` [PATCH 04/13] Use gdb_bfd_sections in get_stap_base_address Tom Tromey
2020-08-28 17:06 ` Simon Marchi
2020-08-28 16:23 ` [PATCH 05/13] Use gdb_bfd_sections in build_objfile_section_table Tom Tromey
2020-08-28 16:23 ` [PATCH 06/13] Use gdb_bfd_sections in symfile.c Tom Tromey
2020-08-28 17:00 ` Simon Marchi
2020-08-28 17:06 ` Simon Marchi
2020-08-28 16:23 ` [PATCH 07/13] Use gdb_bfd_sections in dwarf2/read.c Tom Tromey
2020-08-28 16:23 ` [PATCH 08/13] Use gdb_bfd_sections in ELF osabi tag sniffing Tom Tromey
2020-08-28 16:23 ` [PATCH 09/13] Use gdb_bfd_sections in gcore_memory_sections Tom Tromey
2020-08-28 16:23 ` [PATCH 10/13] Use gdb_bfd_sections in restore_command Tom Tromey
2020-08-28 17:12 ` Simon Marchi
2020-08-29 15:47 ` Tom Tromey
2020-08-29 15:49 ` Simon Marchi
2020-08-28 16:23 ` [PATCH 11/13] Use gdb_bfd_sections in elf_symfile_read Tom Tromey
2020-08-28 16:23 ` [PATCH 12/13] Use gdb_bfd_sections in build_section_table Tom Tromey
2020-08-28 16:23 ` [PATCH 13/13] Use gdb_bfd_sections in generic_load Tom Tromey
2020-08-28 17:14 ` [PATCH 00/13] Use gdb_bfd_sections in more places Simon Marchi
2020-08-31 18:19 ` John Baldwin
2020-09-19 18:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7023e3ad-0200-9eaa-4a77-191b1cc5f567@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox