From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: get_frame_language now takes a frame parameter.
Date: Fri, 07 Aug 2015 09:45:00 -0000 [thread overview]
Message-ID: <55C47E22.30306@redhat.com> (raw)
In-Reply-To: <20150807085557.GA30204@embecosm.com>
On 08/07/2015 09:55 AM, Andrew Burgess wrote:
> New version below.
OK, with ...
>
> * infcmd.c (signal_command): Call do_cleanups for args_chain.
> diff --git a/gdb/language.c b/gdb/language.c
> index a8b432e..75d4497 100644
> --- a/gdb/language.c
> +++ b/gdb/language.c
> @@ -118,7 +118,8 @@ static void
> show_language_command (struct ui_file *file, int from_tty,
> struct cmd_list_element *c, const char *value)
> {
> - enum language flang; /* The language of the current frame. */
> + struct frame_info *frame;
This new variable is only used in the has_stack_frames block, so move the
declaration there please.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-08-07 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 15:40 [PATCH 0/2] Make get_frame_langauge take a frame argument Andrew Burgess
2015-08-04 15:40 ` [PATCH 1/2] gdb: get_frame_language now takes a frame parameter Andrew Burgess
2015-08-04 16:02 ` Pedro Alves
2015-08-07 8:56 ` Andrew Burgess
2015-08-07 9:45 ` Pedro Alves [this message]
2015-08-04 15:40 ` [PATCH 2/2] gdb: Move get_frame_language from stack.c to frame.c Andrew Burgess
2015-08-04 16:02 ` Pedro Alves
2015-08-07 8:57 ` Andrew Burgess
2015-08-07 9:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C47E22.30306@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox