From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48796 invoked by alias); 7 Aug 2015 09:45:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48783 invoked by uid 89); 7 Aug 2015 09:45:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 07 Aug 2015 09:45:09 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5387D39F539; Fri, 7 Aug 2015 09:45:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t779j6GP004365; Fri, 7 Aug 2015 05:45:07 -0400 Message-ID: <55C47E22.30306@redhat.com> Date: Fri, 07 Aug 2015 09:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: get_frame_language now takes a frame parameter. References: <27becf0497c6090b676523ee45069d3e5e6afa17.1438699523.git.andrew.burgess@embecosm.com> <55C0E222.1030006@redhat.com> <20150807085557.GA30204@embecosm.com> In-Reply-To: <20150807085557.GA30204@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00196.txt.bz2 On 08/07/2015 09:55 AM, Andrew Burgess wrote: > New version below. OK, with ... > > * infcmd.c (signal_command): Call do_cleanups for args_chain. > diff --git a/gdb/language.c b/gdb/language.c > index a8b432e..75d4497 100644 > --- a/gdb/language.c > +++ b/gdb/language.c > @@ -118,7 +118,8 @@ static void > show_language_command (struct ui_file *file, int from_tty, > struct cmd_list_element *c, const char *value) > { > - enum language flang; /* The language of the current frame. */ > + struct frame_info *frame; This new variable is only used in the has_stack_frames block, so move the declaration there please. Thanks, Pedro Alves