From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Move get_frame_language from stack.c to frame.c.
Date: Tue, 04 Aug 2015 16:02:00 -0000 [thread overview]
Message-ID: <55C0E229.7050003@redhat.com> (raw)
In-Reply-To: <568a4c1273713e14f691586c2d32bdbd3be610a1.1438699523.git.andrew.burgess@embecosm.com>
On 08/04/2015 04:40 PM, Andrew Burgess wrote:
> --- a/gdb/frame.h
> +++ b/gdb/frame.h
> @@ -814,4 +814,10 @@ extern struct frame_info *create_new_frame (CORE_ADDR base, CORE_ADDR pc);
> extern int frame_unwinder_is (struct frame_info *fi,
> const struct frame_unwind *unwinder);
>
> +/* Return the language of FRAME. */
> +
> +enum language;
No new forward declarations of enums please. That doesn't work in C++.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-08-04 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 15:40 [PATCH 0/2] Make get_frame_langauge take a frame argument Andrew Burgess
2015-08-04 15:40 ` [PATCH 1/2] gdb: get_frame_language now takes a frame parameter Andrew Burgess
2015-08-04 16:02 ` Pedro Alves
2015-08-07 8:56 ` Andrew Burgess
2015-08-07 9:45 ` Pedro Alves
2015-08-04 15:40 ` [PATCH 2/2] gdb: Move get_frame_language from stack.c to frame.c Andrew Burgess
2015-08-04 16:02 ` Pedro Alves [this message]
2015-08-07 8:57 ` Andrew Burgess
2015-08-07 9:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0E229.7050003@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox