Re: [PATCH] Uniquify test names from gdb.python/{py-objfile.exp,py-pp-registration.exp}

[Pedro Alves <palves@redhat.com>]

On 07/28/2015 10:40 PM, Sergio Durigan Junior wrote:
> On Friday, July 24 2015, I wrote:
> 
>> While running some regression tests, I noticed that the two Python
>> tests mentioned in the $SUBJECT contain non-unique names.  This is a
>> violation of our guidelines:
>>
>>   <https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique>
> 
> I went ahead and pushed this:
> 
>   <https://sourceware.org/ml/gdb-cvs/2015-07/msg00195.html>
> 
> Let me know if there is any problem.

There are a _ton_ of non-unique messages in the testsuite.  We need
to be able to move faster with such fixes if we ever want to
reach the state of full uniqueness.

Off the top of my head, if:

 - the change is done with awareness that with_test_prefix might
   be more appropriate at places than an explicit unique message

 - the new messages conform with usual style: message all in lowercase
   with no period at end

 - the patch follows usual conventions -- ChangeLog, self-contained
   commit log, etc.

then I think people should be able to go ahead and be a
more aggressive in pushing such patches in.

BTW, there's an umbrella bug about it:

  https://sourceware.org/bugzilla/show_bug.cgi?id=13443

Thanks,
Pedro Alves