From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21099 invoked by alias); 28 Jul 2015 22:25:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21088 invoked by uid 89); 28 Jul 2015 22:25:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jul 2015 22:25:43 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id ACA778E767 for ; Tue, 28 Jul 2015 22:25:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6SMPewm008625; Tue, 28 Jul 2015 18:25:40 -0400 Message-ID: <55B80163.5070308@redhat.com> Date: Tue, 28 Jul 2015 22:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Sergio Durigan Junior , GDB Patches Subject: Re: [PATCH] Uniquify test names from gdb.python/{py-objfile.exp,py-pp-registration.exp} References: <1437772393-6739-1-git-send-email-sergiodj@redhat.com> <871tfsq7uc.fsf@redhat.com> In-Reply-To: <871tfsq7uc.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00845.txt.bz2 On 07/28/2015 10:40 PM, Sergio Durigan Junior wrote: > On Friday, July 24 2015, I wrote: > >> While running some regression tests, I noticed that the two Python >> tests mentioned in the $SUBJECT contain non-unique names. This is a >> violation of our guidelines: >> >> > > I went ahead and pushed this: > > > > Let me know if there is any problem. There are a _ton_ of non-unique messages in the testsuite. We need to be able to move faster with such fixes if we ever want to reach the state of full uniqueness. Off the top of my head, if: - the change is done with awareness that with_test_prefix might be more appropriate at places than an explicit unique message - the new messages conform with usual style: message all in lowercase with no period at end - the patch follows usual conventions -- ChangeLog, self-contained commit log, etc. then I think people should be able to go ahead and be a more aggressive in pushing such patches in. BTW, there's an umbrella bug about it: https://sourceware.org/bugzilla/show_bug.cgi?id=13443 Thanks, Pedro Alves