Re: [PATCH] Uniquify test names from gdb.python/{py-objfile.exp,py-pp-registration.exp}

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Wednesday, July 29 2015, Pedro Alves wrote:

> Hi Sergio,
>
> This unfortunately caused regressions in the testsuite:
>
> Running /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.python/py-objfile.exp ...
> FAIL: gdb.python/py-objfile.exp: Get no-debug objfile file
> FAIL: gdb.python/py-objfile.exp: Test owner of real objfile.
> FAIL: gdb.python/py-objfile.exp: Add separate debug file file
> FAIL: gdb.python/py-objfile.exp: Test owner of separate debug file
> FAIL: gdb.python/py-objfile.exp: Test user-name of owner of separate debug file
> FAIL: gdb.python/py-objfile.exp: print main with debug info
> FAIL: gdb.python/py-objfile.exp: print lookup_objfile of separate debug file
>
>> -gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \
>> +gdb_py_test_silent_cmd "python objfile = gdb.s()\[0\]" \
>
> Looks like a typo snuck in here.
>
> Breakpoint 1, 0x0000000000400594 in main ()
> (gdb) python objfile = gdb.s()[0]
> Traceback (most recent call last):
>   File "<string>", line 1, in <module>
> AttributeError: 'module' object has no attribute 's'
> Error while executing Python code.
> (gdb) FAIL: gdb.python/py-objfile.exp: Get no-debug objfile file

Ops, thanks for the report.  I confess I have no idea how this happened,
but I pushed a fix.

Sorry about that,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

From dac804dfa6389b71f50b5e169ffa4e239958e774 Mon Sep 17 00:00:00 2001
From: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Wed, 29 Jul 2015 10:16:38 -0400
Subject: [PATCH] Fix typo in gdb.python/py-objfile.exp

My last commit d60a92216e5d599fed6b37c58c744debe38a0b24 introduced a
regression caused by a typo.  This fixes it.  Checked in as obvious.
Thanks to Pedro for reporting.

gdb/testsuite/ChangeLog:
2015-07-29  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.python/py-objfile.exp: Fix typo that snuck in from my last
	commit.
---
 gdb/testsuite/ChangeLog                 | 5 +++++
 gdb/testsuite/gdb.python/py-objfile.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index ee0af2a..1f9bf98 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-07-29  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* gdb.python/py-objfile.exp: Fix typo that snuck in from my last
+	commit.
+
 2015-07-29  Patrick Palka  <patrick@parcs.ath.cx>
 
 	* gdb.base/batch-preserve-term-settings.exp
diff --git a/gdb/testsuite/gdb.python/py-objfile.exp b/gdb/testsuite/gdb.python/py-objfile.exp
index 7dd094c..6e6dfe7 100644
--- a/gdb/testsuite/gdb.python/py-objfile.exp
+++ b/gdb/testsuite/gdb.python/py-objfile.exp
@@ -106,7 +106,7 @@ if ![runto_main] {
     return 0
 }
 
-gdb_py_test_silent_cmd "python objfile = gdb.s()\[0\]" \
+gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \
     "Get no-debug objfile file" 1
 
 gdb_test "python print (objfile.owner)" "None" \
-- 
2.4.3