From: Pierre-Marie de Rodat <derodat@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/gdbtypes: fix handling of typedef layers between array types
Date: Thu, 23 Jul 2015 13:02:00 -0000 [thread overview]
Message-ID: <55B0E5E5.1080000@adacore.com> (raw)
In-Reply-To: <20150723125324.GP7406@adacore.com>
On 07/23/2015 02:53 PM, Joel Brobecker wrote:
> Looks good to go overall, with one nit (missing bit in the copyright
> header of the Ada code, as seen below).
Fixed.
> For the record, I believe the patch was tested on x86_64-linux.
>
> Pre-approved with the nits fixed.
Indeed. If I start using git-send-email, I should say how it's tested in
the commit message. ;-)
Thank you Joel!
--
Pierre-Marie de Rodat
prev parent reply other threads:[~2015-07-23 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 11:47 Pierre-Marie de Rodat
2015-07-23 12:53 ` Joel Brobecker
2015-07-23 13:02 ` Pierre-Marie de Rodat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0E5E5.1080000@adacore.com \
--to=derodat@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox