From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119294 invoked by alias); 23 Jul 2015 13:02:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119277 invoked by uid 89); 23 Jul 2015 13:02:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 13:02:32 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 1A52E28B35D1; Thu, 23 Jul 2015 15:02:30 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QHoQo_lcvAlb; Thu, 23 Jul 2015 15:02:30 +0200 (CEST) Received: from [10.10.1.112] (cacatoes.act-europe.fr [10.10.1.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 0BC2D28B26E1; Thu, 23 Jul 2015 15:02:30 +0200 (CEST) Subject: Re: [PATCH] gdb/gdbtypes: fix handling of typedef layers between array types To: Joel Brobecker References: <1437652042-8237-1-git-send-email-derodat@adacore.com> <20150723125324.GP7406@adacore.com> Cc: gdb-patches@sourceware.org From: Pierre-Marie de Rodat Message-ID: <55B0E5E5.1080000@adacore.com> Date: Thu, 23 Jul 2015 13:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150723125324.GP7406@adacore.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00632.txt.bz2 On 07/23/2015 02:53 PM, Joel Brobecker wrote: > Looks good to go overall, with one nit (missing bit in the copyright > header of the Ada code, as seen below). Fixed. > For the record, I believe the patch was tested on x86_64-linux. > > Pre-approved with the nits fixed. Indeed. If I start using git-send-email, I should say how it's tested in the commit message. ;-) Thank you Joel! -- Pierre-Marie de Rodat