From: Joel Brobecker <brobecker@adacore.com>
To: Pierre-Marie de Rodat <derodat@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/gdbtypes: fix handling of typedef layers between array types
Date: Thu, 23 Jul 2015 12:53:00 -0000 [thread overview]
Message-ID: <20150723125324.GP7406@adacore.com> (raw)
In-Reply-To: <1437652042-8237-1-git-send-email-derodat@adacore.com>
> gdb/ChangeLog:
>
> * gdbtypes.c (resolve_dynamic_array): Pass the peeled element
> type to the recursive call instead of the original (maybe
> TYPE_CODE_TYPEDEF) type.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.ada/var_arr_typedef.exp: New testcase.
> * gdb.ada/var_arr_typedef/pack.adb: New file.
> * gdb.ada/var_arr_typedef/pack.ads: New file.
> * gdb.ada/var_arr_typedef/var_arr_typedef.adb: New file.
Looks good to go overall, with one nit (missing bit in the copyright
header of the Ada code, as seen below).
For the record, I believe the patch was tested on x86_64-linux.
Pre-approved with the nits fixed.
> diff --git a/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb b/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb
> new file mode 100644
> index 0000000..82f034b
> --- /dev/null
> +++ b/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb
> @@ -0,0 +1,23 @@
> +-- This program is free software; you can redistribute it and/or modify
> +-- it under the terms of the GNU General Public License as published by
Missing the "Copyright (C) 2015 Free [...]" line at the start of
this Ada file, and all others.
--
Joel
next prev parent reply other threads:[~2015-07-23 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 11:47 Pierre-Marie de Rodat
2015-07-23 12:53 ` Joel Brobecker [this message]
2015-07-23 13:02 ` Pierre-Marie de Rodat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723125324.GP7406@adacore.com \
--to=brobecker@adacore.com \
--cc=derodat@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox