From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105255 invoked by alias); 23 Jul 2015 12:53:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105241 invoked by uid 89); 23 Jul 2015 12:53:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 23 Jul 2015 12:53:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CD60C2908D; Thu, 23 Jul 2015 08:53:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EfpGLMf+5Nix; Thu, 23 Jul 2015 08:53:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9FEA1289D7; Thu, 23 Jul 2015 08:53:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 390FC41C8C; Thu, 23 Jul 2015 05:53:24 -0700 (PDT) Date: Thu, 23 Jul 2015 12:53:00 -0000 From: Joel Brobecker To: Pierre-Marie de Rodat Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/gdbtypes: fix handling of typedef layers between array types Message-ID: <20150723125324.GP7406@adacore.com> References: <1437652042-8237-1-git-send-email-derodat@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437652042-8237-1-git-send-email-derodat@adacore.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-07/txt/msg00631.txt.bz2 > gdb/ChangeLog: > > * gdbtypes.c (resolve_dynamic_array): Pass the peeled element > type to the recursive call instead of the original (maybe > TYPE_CODE_TYPEDEF) type. > > gdb/testsuite/ChangeLog: > > * gdb.ada/var_arr_typedef.exp: New testcase. > * gdb.ada/var_arr_typedef/pack.adb: New file. > * gdb.ada/var_arr_typedef/pack.ads: New file. > * gdb.ada/var_arr_typedef/var_arr_typedef.adb: New file. Looks good to go overall, with one nit (missing bit in the copyright header of the Ada code, as seen below). For the record, I believe the patch was tested on x86_64-linux. Pre-approved with the nits fixed. > diff --git a/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb b/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb > new file mode 100644 > index 0000000..82f034b > --- /dev/null > +++ b/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb > @@ -0,0 +1,23 @@ > +-- This program is free software; you can redistribute it and/or modify > +-- it under the terms of the GNU General Public License as published by Missing the "Copyright (C) 2015 Free [...]" line at the start of this Ada file, and all others. -- Joel