From: Pedro Alves <palves@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Roland McGrath <mcgrathr@google.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
Date: Fri, 29 May 2015 16:29:00 -0000 [thread overview]
Message-ID: <556893D2.1090907@redhat.com> (raw)
In-Reply-To: <CADPb22T2TU-zaAbuu0qa5yrOdsBVjXVHfezOVYbuKL+8zP7twg@mail.gmail.com>
On 05/29/2015 05:26 PM, Doug Evans wrote:
> On Fri, May 29, 2015 at 3:07 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 05/29/2015 01:21 AM, Roland McGrath wrote:
>>> Diagnosis of unexpected input (in this case, in an executable file)
>>> should not crash as if it were a bug in GDB.
>>> ...
>>> + warning ("GNU ABI tag value %u unrecognized.\n", abi_tag);
>>
>> Wrap string in _().
>
> No trailing \n too, right?
Right.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-05-29 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 0:21 Roland McGrath
2015-05-29 10:07 ` Pedro Alves
2015-05-29 16:26 ` Doug Evans
2015-05-29 16:29 ` Pedro Alves [this message]
2015-05-29 16:32 ` Roland McGrath
2015-05-29 17:00 ` Pedro Alves
2015-05-29 17:34 ` Roland McGrath
2015-05-29 17:36 ` Pedro Alves
2015-05-29 18:21 ` Roland McGrath
2015-05-29 18:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556893D2.1090907@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox