From: Roland McGrath <mcgrathr@google.com>
To: GDB <gdb-patches@sourceware.org>
Subject: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
Date: Fri, 29 May 2015 00:21:00 -0000 [thread overview]
Message-ID: <CAB=4xhoR0=ZaDot6rEaVhhEAxYeoBjP89AHhxgD52ANKKrDYJg@mail.gmail.com> (raw)
Diagnosis of unexpected input (in this case, in an executable file)
should not crash as if it were a bug in GDB. This one is especially
harmless, since the "osabi" has so little effect on anything.
OK for trunk and 7.9 branch?
Thanks,
Roland
gdb/
2015-05-28 Roland McGrath <mcgrathr@google.com>
* osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Use warning
rather than internal_error for an unrecognized value.
diff --git a/gdb/osabi.c b/gdb/osabi.c
index 9d90c55..abf4bd4 100644
--- a/gdb/osabi.c
+++ b/gdb/osabi.c
@@ -493,10 +493,9 @@ generic_elf_osabi_sniff_abi_tag_sections (bfd
*abfd, asection *sect, void *obj)
break;
default:
- internal_error (__FILE__, __LINE__,
- _("generic_elf_osabi_sniff_abi_tag_sections: "
- "unknown OS number %d"),
- abi_tag);
+ warning ("GNU ABI tag value %u unrecognized.\n", abi_tag);
+ *osabi = GDB_OSABI_UNKNOWN;
+ break;
}
return;
}
next reply other threads:[~2015-05-29 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 0:21 Roland McGrath [this message]
2015-05-29 10:07 ` Pedro Alves
2015-05-29 16:26 ` Doug Evans
2015-05-29 16:29 ` Pedro Alves
2015-05-29 16:32 ` Roland McGrath
2015-05-29 17:00 ` Pedro Alves
2015-05-29 17:34 ` Roland McGrath
2015-05-29 17:36 ` Pedro Alves
2015-05-29 18:21 ` Roland McGrath
2015-05-29 18:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=4xhoR0=ZaDot6rEaVhhEAxYeoBjP89AHhxgD52ANKKrDYJg@mail.gmail.com' \
--to=mcgrathr@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox