From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123248-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 108906 invoked by alias); 29 May 2015 16:29:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 108894 invoked by uid 89); 29 May 2015 16:29:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 May 2015 16:29:09 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 3D25CBC910;	Fri, 29 May 2015 16:29:08 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4TGT6GB017291;	Fri, 29 May 2015 12:29:07 -0400
Message-ID: <556893D2.1090907@redhat.com>
Date: Fri, 29 May 2015 16:29:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Doug Evans <dje@google.com>
CC: Roland McGrath <mcgrathr@google.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
References: <CAB=4xhoR0=ZaDot6rEaVhhEAxYeoBjP89AHhxgD52ANKKrDYJg@mail.gmail.com>	<55683A6F.2030600@redhat.com> <CADPb22T2TU-zaAbuu0qa5yrOdsBVjXVHfezOVYbuKL+8zP7twg@mail.gmail.com>
In-Reply-To: <CADPb22T2TU-zaAbuu0qa5yrOdsBVjXVHfezOVYbuKL+8zP7twg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-05/txt/msg00720.txt.bz2

On 05/29/2015 05:26 PM, Doug Evans wrote:
> On Fri, May 29, 2015 at 3:07 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 05/29/2015 01:21 AM, Roland McGrath wrote:
>>> Diagnosis of unexpected input (in this case, in an executable file)
>>> should not crash as if it were a bug in GDB.
>>> ...
>>> +              warning ("GNU ABI tag value %u unrecognized.\n", abi_tag);
>>
>> Wrap string in _().
> 
> No trailing \n too, right?

Right.

Thanks,
Pedro Alves