Re: [patch 1/2] mingw: update gnulib: prepare the sources

[Pedro Alves <palves@redhat.com>]

On 03/23/2015 05:36 PM, Eli Zaretskii wrote:
>> Date: Mon, 23 Mar 2015 17:25:15 +0000
>> From: Pedro Alves <palves@redhat.com>
>> CC: Kai Tietz <ktietz@redhat.com>, gdb-patches@sourceware.org,        Corinna Vinschen <vinschen@redhat.com>,        Nicholas Clifton <nickc@redhat.com>
>>
>>> With this header file used for GDB's sources aren't gnulib's .c files compiled
>>> with incompatible ABI?
>>
>> Other than rpl_gettimeofday (the gettimeofday replacement):
>>
>>   gettimeofday.o:0000005a T _rpl_gettimeofday
>>
>> AFAICS, there's no other use of "struct timeval" or gettimeofday in gnulib's
>> sources.
> 
> We should watch out for Gnulib's 'select' and friends, if we ever want
> to import that.  Also 'utimens'.

Agreed.

I think it's good to first go with this simple approach to unblock a
gnulib import, and then we can always do some more invasive fix on
top, with no rush.

However, it'd be good if someone could make sure that gdb
still actually works on Windows before pushing to master.

I've pushed a gnulib import to current gnulib git to the
users/palves/gnulib-update branch (on sourceware.org).

Can anyone give it a try on Windows?  All I can easily
test is building..

Thanks,
Pedro Alves