Re: [patch 1/2] mingw: update gnulib: prepare the sources

[Pedro Alves <palves@redhat.com>]

On 03/23/2015 07:17 PM, Corinna Vinschen wrote:
> On Mar 23 16:51, Pedro Alves wrote:
>> Hi guys,
>>
>> We really need to move forward with importing a newer gnulib,
>> for several reasons...
> 
> I'm not quite sure why I'm CCed on this thread, 

Dunno, I just hit reply to all.

> but please keep in mind
> that Cygwin tries hard to be a POSIX platform.  Please, don't mix Windows
> headers and Windows calls in, unless you really, *really* need them.
> 
> Especially don't mix in winsock headers and the definitions of timeval,
> they collide with the POSIX definitions in the newlib headers.

Yep, don't worry, that's not being proposed.  Even Jan's original patch
limited the windows.h inclusion to mingw.  If a gnulib header ends up
pulling windows.h on Cygwin, that'd be a gnulib bug.  I think the chances
of that happening without the gnulib folks noticing are quite low
though.

But the best way to make sure is to test the users/palves/gnulib-update branch.  :-)

Thanks,
Pedro Alves