From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3825 invoked by alias); 23 Mar 2015 17:57:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2669 invoked by uid 89); 23 Mar 2015 17:57:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Mar 2015 17:57:57 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 06F57AC7B1; Mon, 23 Mar 2015 17:57:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2NHvqOl016442; Mon, 23 Mar 2015 13:57:53 -0400 Message-ID: <55105420.40105@redhat.com> Date: Mon, 23 Mar 2015 17:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii CC: jan.kratochvil@redhat.com, ktietz@redhat.com, gdb-patches@sourceware.org, vinschen@redhat.com, nickc@redhat.com Subject: Re: [patch 1/2] mingw: update gnulib: prepare the sources References: <20141222221229.GA30575@host2.jankratochvil.net> <108241234.1319759.1419335690162.JavaMail.zimbra@redhat.com> <20141224222045.GA30482@host2.jankratochvil.net> <551044A0.9070607@redhat.com> <20150323170830.GA8493@host1.jankratochvil.net> <55104C7B.9060405@redhat.com> <83mw33r4y3.fsf@gnu.org> In-Reply-To: <83mw33r4y3.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00730.txt.bz2 On 03/23/2015 05:36 PM, Eli Zaretskii wrote: >> Date: Mon, 23 Mar 2015 17:25:15 +0000 >> From: Pedro Alves >> CC: Kai Tietz , gdb-patches@sourceware.org, Corinna Vinschen , Nicholas Clifton >> >>> With this header file used for GDB's sources aren't gnulib's .c files compiled >>> with incompatible ABI? >> >> Other than rpl_gettimeofday (the gettimeofday replacement): >> >> gettimeofday.o:0000005a T _rpl_gettimeofday >> >> AFAICS, there's no other use of "struct timeval" or gettimeofday in gnulib's >> sources. > > We should watch out for Gnulib's 'select' and friends, if we ever want > to import that. Also 'utimens'. Agreed. I think it's good to first go with this simple approach to unblock a gnulib import, and then we can always do some more invasive fix on top, with no rush. However, it'd be good if someone could make sure that gdb still actually works on Windows before pushing to master. I've pushed a gnulib import to current gnulib git to the users/palves/gnulib-update branch (on sourceware.org). Can anyone give it a try on Windows? All I can easily test is building.. Thanks, Pedro Alves