From: Luis Machado <lgustavo@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, v2] Fix ARM machine state testcase failures
Date: Mon, 27 Oct 2014 11:03:00 -0000 [thread overview]
Message-ID: <544E2665.4080409@codesourcery.com> (raw)
In-Reply-To: <5446FFA5.2040209@codesourcery.com>
On 10/21/2014 10:51 PM, Luis Machado wrote:
> On 10/21/2014 11:03 AM, Yao Qi wrote:
>> Luis Machado <lgustavo@codesourcery.com> writes:
>>
>>> + /* Handle bit P. */
>>> + if (bit (arm_insn_r->arm_insn, 24))
>>> + {
>>> + record_buf_mem[1] = tgt_mem_addr;
>>> + }
>>> + else
>>> + {
>>> + record_buf_mem[1] = (uint32_t) u_regval;
>>> + }
>>
>> These braces are not necessary.
>>
>
> Thanks. Comments addressed in the attached updated patch. I added
> another check for wback so we only save the base register when needed.
>
> I plan to commit this version in a couple days unless there are objections.
>
> Luis
I've checked this in now.
Thanks,
Luis
prev parent reply other threads:[~2014-10-27 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 12:03 Luis Machado
2014-10-21 12:16 ` Luis Machado
2014-10-21 12:49 ` Yao Qi
2014-10-21 13:07 ` Yao Qi
2014-10-22 0:52 ` Luis Machado
2014-10-27 11:03 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E2665.4080409@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox