From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117058-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19790 invoked by alias); 27 Oct 2014 11:03:17 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 19776 invoked by uid 89); 27 Oct 2014 11:03:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Oct 2014 11:03:09 +0000
Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43])	by relay1.mentorg.com with esmtp 	id 1Xii4o-0003PE-A8 from Luis_Gustavo@mentor.com 	for gdb-patches@sourceware.org; Mon, 27 Oct 2014 04:03:06 -0700
Received: from [172.30.15.143] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.181.6; Mon, 27 Oct 2014 04:03:05 -0700
Message-ID: <544E2665.4080409@codesourcery.com>
Date: Mon, 27 Oct 2014 11:03:00 -0000
From: Luis Machado <lgustavo@codesourcery.com>
Reply-To: <lgustavo@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, v2] Fix ARM machine state testcase failures
References: <54464B82.6030703@codesourcery.com> <87k33tingn.fsf@codesourcery.com> <5446FFA5.2040209@codesourcery.com>
In-Reply-To: <5446FFA5.2040209@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00734.txt.bz2

On 10/21/2014 10:51 PM, Luis Machado wrote:
> On 10/21/2014 11:03 AM, Yao Qi wrote:
>> Luis Machado <lgustavo@codesourcery.com> writes:
>>
>>> +      /* Handle bit P.  */
>>> +      if (bit (arm_insn_r->arm_insn, 24))
>>> +    {
>>> +      record_buf_mem[1] = tgt_mem_addr;
>>> +    }
>>> +      else
>>> +    {
>>> +       record_buf_mem[1] = (uint32_t) u_regval;
>>> +    }
>>
>> These braces are not necessary.
>>
>
> Thanks. Comments addressed in the attached updated patch. I added
> another check for wback so we only save the base register when needed.
>
> I plan to commit this version in a couple days unless there are objections.
>
> Luis

I've checked this in now.

Thanks,
Luis