From: Jan Vrany <jan.vrany@fit.cvut.cz>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command
Date: Fri, 10 Aug 2018 08:29:00 -0000 [thread overview]
Message-ID: <54305efb91661439bd417c7229b82f725308c7d4.camel@fit.cvut.cz> (raw)
In-Reply-To: <877ekz6ze7.fsf@tromey.com>
On Thu, 2018-08-09 at 14:47 -0600, Tom Tromey wrote:
> > > > > > Jan> - if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen)
> Jan> - || (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
> Jan> - || (!line_seen && !file_seen && !num_seen && start_seen && end_seen)))
> Jan> + if (!( ( line_seen && file_seen && !start_seen && !end_seen && !addr_seen)
> Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen)
> Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen)))
>
> These go over 80 columns now, so I think they need to be reformatted
> somehow to fit.
Hi, that'd be tricky but I'll do my best...
> Please use your judgment, what you did here is already
> better than the status quo...
>
> No need to re-post the patch, you can just put it in with the
> correction. Thank you.
I do not have commit access to the repo (it's my preference for the moment).
New patch will follow shortly. Simon, could you please push it for me if
it's OK?
Thanks!
Jan
next prev parent reply other threads:[~2018-08-10 8:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:39 Jan Vrany
2018-07-06 12:37 ` Eli Zaretskii
2018-07-14 17:39 ` Jan Vrany
2018-07-14 18:27 ` Eli Zaretskii
2018-07-26 14:56 ` Jan Vrany
2018-07-26 17:47 ` Eli Zaretskii
2018-07-27 7:57 ` Jan Vrany
2018-07-30 15:05 ` Tom Tromey
2018-07-31 10:23 ` Jan Vrany
2018-07-31 15:48 ` Tom Tromey
2018-07-31 20:35 ` Jan Vrany
2018-08-09 20:47 ` Tom Tromey
2018-08-10 8:29 ` Jan Vrany [this message]
2018-08-10 13:22 ` Tom Tromey
2018-08-10 8:30 ` Jan Vrany
2018-08-10 9:47 ` Pedro Alves
2018-08-10 10:28 ` Jan Vrany
2018-08-10 10:41 ` Pedro Alves
2018-08-14 9:16 ` Jan Vrany
2018-08-14 13:57 ` Pedro Alves
2018-08-14 14:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54305efb91661439bd417c7229b82f725308c7d4.camel@fit.cvut.cz \
--to=jan.vrany@fit.cvut.cz \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox