From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126734 invoked by alias); 10 Aug 2018 08:29:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125090 invoked by uid 89); 10 Aug 2018 08:28:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay.fit.cvut.cz Received: from relay.fit.cvut.cz (HELO relay.fit.cvut.cz) (147.32.232.237) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 08:28:30 +0000 Received: from imap.fit.cvut.cz (imap.fit.cvut.cz [147.32.232.238]) by relay.fit.cvut.cz (8.15.2/8.15.2) with ESMTPS id w7A8SOBP030424 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Fri, 10 Aug 2018 10:28:26 +0200 (CEST) (envelope-from jan.vrany@fit.cvut.cz) Received: from sao (5ac693bc.bb.sky.com [90.198.147.188] (may be forged)) (authenticated bits=0 as user vranyj1) by imap.fit.cvut.cz (8.15.2/8.15.2) with ESMTPSA id w7A8SNLx028253 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 10 Aug 2018 10:28:23 +0200 (CEST) (envelope-from jan.vrany@fit.cvut.cz) Message-ID: <54305efb91661439bd417c7229b82f725308c7d4.camel@fit.cvut.cz> Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command From: Jan Vrany To: gdb-patches@sourceware.org Cc: Tom Tromey Date: Fri, 10 Aug 2018 08:29:00 -0000 In-Reply-To: <877ekz6ze7.fsf@tromey.com> References: <87k1pb4dag.fsf@tromey.com> <20180731203424.31866-1-jan.vrany@fit.cvut.cz> <877ekz6ze7.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00261.txt.bz2 On Thu, 2018-08-09 at 14:47 -0600, Tom Tromey wrote: > > > > > > Jan> - if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen) > Jan> - || (line_seen && file_seen && !num_seen && !start_seen && !end_seen) > Jan> - || (!line_seen && !file_seen && !num_seen && start_seen && end_seen))) > Jan> + if (!( ( line_seen && file_seen && !start_seen && !end_seen && !addr_seen) > Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen) > Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen))) > > These go over 80 columns now, so I think they need to be reformatted > somehow to fit. Hi, that'd be tricky but I'll do my best... > Please use your judgment, what you did here is already > better than the status quo... > > No need to re-post the patch, you can just put it in with the > correction. Thank you. I do not have commit access to the repo (it's my preference for the moment). New patch will follow shortly. Simon, could you please push it for me if it's OK? Thanks! Jan