Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Vrany <jan.vrany@fit.cvut.cz>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command
Date: Sat, 14 Jul 2018 18:27:00 -0000	[thread overview]
Message-ID: <83pnzpad0o.fsf@gnu.org> (raw)
In-Reply-To: <20180714173931.10006-1-jan.vrany@fit.cvut.cz> (message from Jan	Vrany on Sat, 14 Jul 2018 18:39:31 +0100)

> From: Jan Vrany <jan.vrany@fit.cvut.cz>
> Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
> Date: Sat, 14 Jul 2018 18:39:31 +0100
> 
> A CLI command "disassemble" allows use to specify a single
> address - in that case function surrounding that address is
> disassembled.

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 839466e7e0..3367be4375 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>  
>  *** Changes since GDB 8.1
>  
> +* The '-data-disassemble' MI command now accepts an '-a' option to disassemble
> +  the whole function surrounding given program counter value or function name.
> +
>  * The 'symbol-file' command now accepts an '-o' option to add a relative
>    offset to all sections.

This part is okay.

> +@item @var{addr}
> +is the address anywhere in function code (or function name).  If @var{addr}
> +is specified, the whole function surrounding that address will be disassembled.
> +Id @var{addr} is a function name, the whole function with that name will be
   ^^
Typo.

Otherwise, the documentation part is approved.


  reply	other threads:[~2018-07-14 18:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06  9:39 Jan Vrany
2018-07-06 12:37 ` Eli Zaretskii
2018-07-14 17:39   ` Jan Vrany
2018-07-14 18:27     ` Eli Zaretskii [this message]
2018-07-26 14:56       ` Jan Vrany
2018-07-26 17:47         ` Eli Zaretskii
2018-07-27  7:57           ` Jan Vrany
2018-07-30 15:05             ` Tom Tromey
2018-07-31 10:23               ` Jan Vrany
2018-07-31 15:48                 ` Tom Tromey
2018-07-31 20:35                   ` Jan Vrany
2018-08-09 20:47                     ` Tom Tromey
2018-08-10  8:29                       ` Jan Vrany
2018-08-10 13:22                         ` Tom Tromey
2018-08-10  8:30                       ` Jan Vrany
2018-08-10  9:47                         ` Pedro Alves
2018-08-10 10:28                           ` Jan Vrany
2018-08-10 10:41                             ` Pedro Alves
2018-08-14  9:16                               ` Jan Vrany
2018-08-14 13:57                                 ` Pedro Alves
2018-08-14 14:40                                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pnzpad0o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.vrany@fit.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox