From: Matthieu Longo <matthieu.longo@arm.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2] gdb: align siginfo_t with the Linux kernel definition
Date: Mon, 29 Jun 2026 10:56:29 +0100 [thread overview]
Message-ID: <53aa6ce6-2d81-4182-ab68-92dd66a4fc93@arm.com> (raw)
In-Reply-To: <87se68h2vo.fsf@linaro.org>
On 27/06/2026 08:13, Thiago Jung Bauermann wrote:
> Hello Matthieu,
>
> Sorry, I just noticed one small nit now:
>
> Matthieu Longo <matthieu.longo@arm.com> writes:
>
>> + /* End _sigfault's anonymous union. */
>> +
>> + /* _sigfault is set by SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGTRAP, SIGEMT */
>> type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
>> append_composite_type_field (type, "si_addr", void_ptr_type);
>> + /* Since there is no possiblity to declare an anonymous union,
>
> Typo: possiblity
>
> No need to send a v3 just because of this. You can adjust this locally
> before committing if this version is approved.
>
>> + using '_' instead. */
>> + append_composite_type_field (type, "_", sigfault_union_type);
>> append_composite_type_field (sifields_type, "_sigfault", type);
>>
>> /* _sigpoll */
>
Fixed locally.
Thanks.
Do you know by any chance of a specific maintainer that should be tagged to review this patch ?
Are the people in copy the right ones ?
Matthieu
next prev parent reply other threads:[~2026-06-29 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 19:39 Matthieu Longo
2026-06-27 7:13 ` Thiago Jung Bauermann
2026-06-29 9:56 ` Matthieu Longo [this message]
2026-07-01 5:28 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53aa6ce6-2d81-4182-ab68-92dd66a4fc93@arm.com \
--to=matthieu.longo@arm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox