From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Matthieu Longo <matthieu.longo@arm.com>
Cc: <gdb-patches@sourceware.org>, Tom Tromey <tom@tromey.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2] gdb: align siginfo_t with the Linux kernel definition
Date: Sat, 27 Jun 2026 07:13:47 +0000 [thread overview]
Message-ID: <87se68h2vo.fsf@linaro.org> (raw)
In-Reply-To: <20260625193933.7994-1-matthieu.longo@arm.com> (Matthieu Longo's message of "Thu, 25 Jun 2026 20:39:33 +0100")
Hello Matthieu,
Sorry, I just noticed one small nit now:
Matthieu Longo <matthieu.longo@arm.com> writes:
> + /* End _sigfault's anonymous union. */
> +
> + /* _sigfault is set by SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGTRAP, SIGEMT */
> type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> append_composite_type_field (type, "si_addr", void_ptr_type);
> + /* Since there is no possiblity to declare an anonymous union,
Typo: possiblity
No need to send a v3 just because of this. You can adjust this locally
before committing if this version is approved.
> + using '_' instead. */
> + append_composite_type_field (type, "_", sigfault_union_type);
> append_composite_type_field (sifields_type, "_sigfault", type);
>
> /* _sigpoll */
--
Thiago
(he/him)
next prev parent reply other threads:[~2026-06-27 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 19:39 Matthieu Longo
2026-06-27 7:13 ` Thiago Jung Bauermann [this message]
2026-06-29 9:56 ` Matthieu Longo
2026-07-01 5:28 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87se68h2vo.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=matthieu.longo@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox