Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix the processing of Meta-key commands in TUI
Date: Thu, 28 Aug 2014 11:31:00 -0000	[thread overview]
Message-ID: <53FF12FF.3020003@redhat.com> (raw)
In-Reply-To: <1408740286-29326-1-git-send-email-patrick@parcs.ath.cx>

On 08/22/2014 09:44 PM, Patrick Palka wrote:
> +
> +  if (async_command_editing_p && key_is_start_sequence (ch))

I think the key_is_start_sequence check means that we'll
fail to compensate in case the sequence if longer than
2 bytes?  That is, we'll compensate for the second char,
but fail to compensate for the third, because by then,
ch will not be a start sequence key.

> +    {
> +      int ch_pending;
> +
> +      nodelay (w, TRUE);
> +      ch_pending = wgetch (w);
> +      nodelay (w, FALSE);
> +

Thanks,
Pedro Alves


  parent reply	other threads:[~2014-08-28 11:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 20:44 Patrick Palka
2014-08-27 17:06 ` Pedro Alves
2014-08-27 18:25   ` Patrick Palka
2014-08-28 11:22     ` Pedro Alves
2014-08-28 13:10       ` Patrick Palka
2014-08-28 14:13       ` Patrick Palka
2014-08-28 15:59         ` Pedro Alves
2014-08-28 16:22           ` Patrick Palka
2014-08-28 17:41         ` Patrick Palka
2014-08-28 17:44           ` Patrick Palka
2014-08-28 11:31 ` Pedro Alves [this message]
2014-08-28 14:18   ` Patrick Palka
2014-08-28 16:13     ` Pedro Alves
2014-08-28 16:26       ` Patrick Palka
2014-11-14 19:12       ` Patrick Palka
2014-11-23 10:08         ` Joel Brobecker
2014-11-23 12:41           ` Patrick Palka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FF12FF.3020003@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=patrick@parcs.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox