From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30843 invoked by alias); 28 Aug 2014 11:31:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30832 invoked by uid 89); 28 Aug 2014 11:31:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Aug 2014 11:31:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7SBVDQi018085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 Aug 2014 07:31:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7SBVCtm017324; Thu, 28 Aug 2014 07:31:12 -0400 Message-ID: <53FF12FF.3020003@redhat.com> Date: Thu, 28 Aug 2014 11:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix the processing of Meta-key commands in TUI References: <1408740286-29326-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1408740286-29326-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00599.txt.bz2 On 08/22/2014 09:44 PM, Patrick Palka wrote: > + > + if (async_command_editing_p && key_is_start_sequence (ch)) I think the key_is_start_sequence check means that we'll fail to compensate in case the sequence if longer than 2 bytes? That is, we'll compensate for the second char, but fail to compensate for the third, because by then, ch will not be a start sequence key. > + { > + int ch_pending; > + > + nodelay (w, TRUE); > + ch_pending = wgetch (w); > + nodelay (w, FALSE); > + Thanks, Pedro Alves