From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, gdb-patches@sourceware.org
Cc: Yao Qi <yao@codesourcery.com>
Subject: Re: [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks
Date: Tue, 29 Jul 2014 12:53:00 -0000 [thread overview]
Message-ID: <53D79621.8050805@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1407231529220.16254@tp.orcam.me.uk>
Looks good to me.
I wonder though, whether:
On 07/24/2014 11:39 PM, Maciej W. Rozycki wrote:
> +set savedtimeout $timeout
> +if { [target_info exists gdb,timeout]
> + && $timeout < [target_info gdb,timeout] } {
> + set oldtimeout [target_info gdb,timeout]
> +} else {
> + set oldtimeout $timeout
> +}
> +set timeout [expr $oldtimeout * 2]
... this pattern can be somewhat factored into a
procedure? That'd also serve the duty of being the
simple place we document it.
> gdb_test "continue" "\[process \[0-9\]+ .*" "continue to signal exit" \
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-07-29 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 22:39 [PATCH 1/2] GDB/testsuite: Avoid timeout lowering Maciej W. Rozycki
2014-07-25 1:41 ` [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks Maciej W. Rozycki
2014-07-29 12:53 ` Pedro Alves [this message]
2014-09-09 16:32 ` Maciej W. Rozycki
2014-07-25 8:36 ` [PATCH 1/2] GDB/testsuite: Avoid timeout lowering Yao Qi
2014-07-29 12:35 ` Pedro Alves
2014-09-09 15:56 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D79621.8050805@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox