Re: [PATCH 1/2] GDB/testsuite: Avoid timeout lowering

["Maciej W. Rozycki" <macro@codesourcery.com>]

On Tue, 29 Jul 2014, Pedro Alves wrote:

> >> 2. Any timeout argument takes precedence.  This is for special cases such 
> >>    as within the framework library code, e.g. it doesn't make sense to 
> >>    send `set height 0' with a timeout of 7200 seconds.  This is a local 
> >>    command that does not interact with the target and setting a high 
> >>    timeout here only risks a test suite run taking ages if it goes astray 
> >>    for some reason.
> 
> Indeed.  It feels like a host vs target timeout concept.  That is, we
> can still have a slow remote host, but that's a different vector of
> slow vs a slow target.

 Hmm, we may consider making the distinction more prominent somehow.  No 
idea outright exactly how, however I'll see if anything smart pops into my 
mind sometime.

> >> 3. The fallback timeout of 60s remains.
> > 
> > Maciej,
> > IWBN to put the descriptions about timeout selection into the comments
> > of proc gdb_expect.
> 
> Agreed.  Or even somewhere more central, and have gdb_expect
> gdb_test_multiple, etc. refer to that.

 I'll think about it, unless any of you beats me to it. ;)

> > I don't see anything wrong in this patch.
> 
> Me neither.

 Applied now, thanks for your review.

  Maciej