From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114618-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12422 invoked by alias); 29 Jul 2014 12:40:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11710 invoked by uid 89); 29 Jul 2014 12:40:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Jul 2014 12:40:07 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6TCe33a020824	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Tue, 29 Jul 2014 08:40:04 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6TCe2GD028393;	Tue, 29 Jul 2014 08:40:02 -0400
Message-ID: <53D79621.8050805@redhat.com>
Date: Tue, 29 Jul 2014 12:53:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: "Maciej W. Rozycki" <macro@codesourcery.com>, gdb-patches@sourceware.org
CC: Yao Qi <yao@codesourcery.com>
Subject: Re: [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks
References: <alpine.DEB.1.10.1407231515400.16254@tp.orcam.me.uk> <alpine.DEB.1.10.1407231529220.16254@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1407231529220.16254@tp.orcam.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-07/txt/msg00723.txt.bz2

Looks good to me.

I wonder though, whether:

On 07/24/2014 11:39 PM, Maciej W. Rozycki wrote:
> +set savedtimeout $timeout
> +if { [target_info exists gdb,timeout]
> +     && $timeout < [target_info gdb,timeout] } {
> +    set oldtimeout [target_info gdb,timeout]
> +} else {
> +    set oldtimeout $timeout
> +}
> +set timeout [expr $oldtimeout * 2]

... this pattern can be somewhat factored into a
procedure? That'd also serve the duty of being the
simple place we document it.

>  gdb_test "continue" "\[process \[0-9\]+ .*" "continue to signal exit" \


Thanks,
Pedro Alves